Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk update improvements #1428

Merged
merged 5 commits into from Jul 12, 2021
Merged

Bulk update improvements #1428

merged 5 commits into from Jul 12, 2021

Conversation

joshbuddy
Copy link
Contributor

This exposes a stats() function on the operation helper that gets returned by bulk(). As well, it tracks the number of noop results. Let me know if you have any feedback on this pr, thanks!

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@stale
Copy link

stale bot commented Jun 11, 2021

We understand that this might be important for you, but this issue has been automatically marked as stale because it has not had recent activity either from our end or yours.
It will be closed if no further activity occurs, please write a comment if you would like to keep this going.

Note: in the past months we have built a new client, that has just landed in master. If you want to open an issue or a pr for the legacy client, you should do that in https://github.com/elastic/elasticsearch-js-legacy

@stale stale bot added the stale label Jun 11, 2021
@stale stale bot removed the stale label Jun 21, 2021
@stale
Copy link

stale bot commented Jul 8, 2021

We understand that this might be important for you, but this issue has been automatically marked as stale because it has not had recent activity either from our end or yours.
It will be closed if no further activity occurs, please write a comment if you would like to keep this going.

Note: in the past months we have built a new client, that has just landed in master. If you want to open an issue or a pr for the legacy client, you should do that in https://github.com/elastic/elasticsearch-js-legacy

@stale stale bot added the stale label Jul 8, 2021
@joshbuddy
Copy link
Contributor Author

How does someone get an improvement to this client who doesn't work at Elastic reviewed? Are outside contributions ever considered?

@stale stale bot removed the stale label Jul 8, 2021
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Apologies for the delay!
The pr looks fantastic, both features are very useful, thanks!

How about expose the stats as a getter?

const helper {
  get stats () {
    return stats
  },
  ...
}

@cla-checker-service
Copy link

cla-checker-service bot commented Jul 12, 2021

💚 CLA has been signed

@joshbuddy
Copy link
Contributor Author

@delvedor I've updated the PR, thanks

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit f2d8cf7 into elastic:master Jul 12, 2021
@joshbuddy
Copy link
Contributor Author

@delvedor Thanks for your help!

@joshbuddy joshbuddy deleted the bulk-update-improvements branch July 12, 2021 14:05
delvedor pushed a commit that referenced this pull request Jul 12, 2021
delvedor pushed a commit that referenced this pull request Jul 12, 2021
@delvedor
Copy link
Member

Thank you too! This change will land in v7.14 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants