New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk update improvements #1428
Bulk update improvements #1428
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
We understand that this might be important for you, but this issue has been automatically marked as stale because it has not had recent activity either from our end or yours. Note: in the past months we have built a new client, that has just landed in master. If you want to open an issue or a pr for the legacy client, you should do that in https://github.com/elastic/elasticsearch-js-legacy |
We understand that this might be important for you, but this issue has been automatically marked as stale because it has not had recent activity either from our end or yours. Note: in the past months we have built a new client, that has just landed in master. If you want to open an issue or a pr for the legacy client, you should do that in https://github.com/elastic/elasticsearch-js-legacy |
How does someone get an improvement to this client who doesn't work at Elastic reviewed? Are outside contributions ever considered? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Apologies for the delay!
The pr looks fantastic, both features are very useful, thanks!
How about expose the stats as a getter?
const helper {
get stats () {
return stats
},
...
}
💚 CLA has been signed |
@delvedor I've updated the PR, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@delvedor Thanks for your help! |
Thank you too! This change will land in v7.14 :) |
This exposes a
stats()
function on the operation helper that gets returned bybulk()
. As well, it tracks the number ofnoop
results. Let me know if you have any feedback on this pr, thanks!