Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated typings #819

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Updated typings #819

merged 1 commit into from
Apr 17, 2019

Conversation

delvedor
Copy link
Member

Follow-up on suggestions from #813 and #817.

@delvedor delvedor merged commit c6ce062 into master Apr 17, 2019
@delvedor delvedor deleted the improve-typings branch April 17, 2019 09:23
delvedor added a commit that referenced this pull request Apr 17, 2019
delvedor added a commit that referenced this pull request Apr 17, 2019
delvedor added a commit that referenced this pull request Apr 17, 2019
@delvedor delvedor mentioned this pull request Apr 17, 2019
@onehorsetown
Copy link
Contributor

@delvedor

Thanks for this PR. One last suggestion.

export interface RequestEvent<T = any> {
    body: any;
    ...

should be:

export interface RequestEvent<T = any> {
    body: T;
    ...

As it is now, it RequestEvent is not using the parameterized type T

export interface RequestEvent<T = any> {

@delvedor
Copy link
Member Author

@onehorsetown good catch!!
Do you want to open a pull request? :)

delvedor pushed a commit that referenced this pull request Apr 19, 2019
Updated `RequestEvent` to use parameterized type `T`.  In reference to:

#819 (comment)
delvedor pushed a commit that referenced this pull request Apr 19, 2019
Updated `RequestEvent` to use parameterized type `T`.  In reference to:

#819 (comment)
delvedor pushed a commit that referenced this pull request Apr 19, 2019
Updated `RequestEvent` to use parameterized type `T`.  In reference to:

#819 (comment)
delvedor pushed a commit that referenced this pull request Apr 19, 2019
Updated `RequestEvent` to use parameterized type `T`.  In reference to:

#819 (comment)
superdev728 added a commit to superdev728/elasticsearch-js that referenced this pull request Jun 1, 2023
Updated `RequestEvent` to use parameterized type `T`.  In reference to:

elastic/elasticsearch-js#819 (comment)
ZeusMystery added a commit to ZeusMystery/elasticsearch that referenced this pull request Dec 20, 2023
Updated `RequestEvent` to use parameterized type `T`.  In reference to:

elastic/elasticsearch-js#819 (comment)
ZeusMystery added a commit to ZeusMystery/elasticsearch that referenced this pull request Dec 20, 2023
Updated `RequestEvent` to use parameterized type `T`.  In reference to:

elastic/elasticsearch-js#819 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants