Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyName should resolve to the last token #1708

Closed
gmarz opened this issue Jan 11, 2016 · 0 comments
Closed

PropertyName should resolve to the last token #1708

gmarz opened this issue Jan 11, 2016 · 0 comments
Assignees

Comments

@gmarz
Copy link
Contributor

gmarz commented Jan 11, 2016

Since dots are no longer allowed in field names since ES 2.0, it makes sense for PropertyName to always resolve to the last token.

For instance

 .Fields(fs => fs
    .String(s => s
        .Name(p => p.Foo.Suffix("raw"))
    )
)

or

 .Fields(fs => fs
    .String(s => s
        .Name("foo.raw")
    )
)

should resolve to just raw.

Relates #1707

@gmarz gmarz added the v2.0.0 label Jan 11, 2016
@gmarz gmarz added this to the 2.0.0 RC milestone Jan 14, 2016
@gmarz gmarz removed this from the 2.0.0 milestone Jan 25, 2016
@Mpdreamz Mpdreamz assigned Mpdreamz and gmarz and unassigned Mpdreamz Jan 26, 2016
@gmarz gmarz closed this as completed in 4ede4c6 Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants