Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back metrics and trace #1762

Closed
gmarz opened this issue Jan 27, 2016 · 5 comments
Closed

Bring back metrics and trace #1762

gmarz opened this issue Jan 27, 2016 · 5 comments
Assignees

Comments

@gmarz
Copy link
Contributor

gmarz commented Jan 27, 2016

Two features from 1.x that have been removed in master due to refactoring are MetricsEnabled() and TraceEnabled(). We should add them back, and I think trace can leverage the new AuditTrail bits?

@Mpdreamz
Copy link
Member

I'm fine with leaving Trace out, i rather introduce LibLog and log .DebugInformation on INFO.

Our audit trail already gives timings for each individual step in the pipeline but not per step what the time to first byte / attempted serialization/deserialization time was.

This would be awesome to bring back through metrics, however if we can do it always in a low allocation fashion that'd be awesome++.

@maeserichar
Copy link
Contributor

So in case we want to log the API requests, what should be the way in the 2.x version?

@Mpdreamz
Copy link
Member

Specifiy a handler on ConnectionSettings for OnRequestCompleted()

@maeserichar
Copy link
Contributor

Great, thanks!

@Mpdreamz Mpdreamz self-assigned this Nov 29, 2016
@Mpdreamz Mpdreamz added v5.0.0 and removed Vote labels Nov 29, 2016
@Mpdreamz
Copy link
Member

Closing this as the path forward is DiagnosticSource for tracing and EventCounter for metrics. Both of which have landed in the client and we'll look to augment, stabalize and document for the 8.0.0 release.

cc @russcam @codebrain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants