DeleteById will delete index if id parameter is null

[jamiegaines]

The ElasticClient.DeleteById(string index, string type, string id) overload will delete the entire index if id happens to be null.

I'm not sure if this is desired behavior or not, but it might be nice to have a ThrowIfNull inside the method.

I'm using NEST in a windows service and saw my whole index of 190k documents wiped out because of a data bug on my part.

Yes, I should have checked for a null id value before calling the method. I admit it. :) But I was a bit surprised that NEST just deleted the whole index because of my oversight.

I love the product. Keep up the great work.

[Mpdreamz]

Yikes, this is a big one! The oversight is entirely on my end. Will jump on this tomorrow morning and add some tests on all the delete calls for null refs.
Thanks for being understanding :)

[Mpdreamz]

Pushed a fix + test for this, but sadly referenced the wrong issue in the commit message :)