Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisableAutomaticProxyDetection defaults to true #866

Closed
Mpdreamz opened this issue Aug 12, 2014 · 2 comments
Closed

DisableAutomaticProxyDetection defaults to true #866

Mpdreamz opened this issue Aug 12, 2014 · 2 comments

Comments

@Mpdreamz
Copy link
Member

Would be better to make the setting a bool? so that it defaults to whatever the BCL default is, but that would break bwc.

@Mpdreamz Mpdreamz added the 2.0 label Aug 12, 2014
@Mpdreamz
Copy link
Member Author

Another option would be to default to false, this would make the client work better with fiddler out of the box. Does this qualify as a backwards compatibility breaking change though?

We've seen more people being hit by slow initial requests due to .Proxy NOT being null then due to it being null as was seen in #809 which is the main reason for defaulting to true.

@gmarz
Copy link
Contributor

gmarz commented Aug 13, 2014

I don't think changing the default back to false would be considered a bwc breaking change, and it's the best option IMO since it takes the path of least resistance. Users who had to change the setting to false since 1.0 to work with Fiddler won't be affected, and the smaller group of users who experience slow initial requests due to it not being null (#809) still have the option to disable it.

Defaulting to false also makes sense given the name of the setting and the fact that the optional parameter (enabled) defaults to true.

@Mpdreamz Mpdreamz removed the 2.0 label Aug 22, 2014
@Mpdreamz Mpdreamz added this to the NEST 1.1 milestone Aug 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants