Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in NodePool documentation about SimpleNodePool #1269

Closed
fgravelaine opened this issue Dec 9, 2022 · 1 comment
Closed

Typo in NodePool documentation about SimpleNodePool #1269

fgravelaine opened this issue Dec 9, 2022 · 1 comment

Comments

@fgravelaine
Copy link
Contributor

Summary of problem or feature request

The NodePool documentation has a typo. (SimpleNodePool constructor takes a SelectorInterface as first argument)

Code snippet of problem

use Elastic\Transport\NodePool\Resurrect\ElasticsearchResurrect;
use Elastic\Transport\NodePool\Selector\RoundRobin;
use Elastic\Transport\NodePool\SimpleNodePool;

$nodePool = new SimpleNodePool(
    new SimpleNodePool(),
    new ElasticsearchResurrect()
);

instead of

$nodePool = new SimpleNodePool(
    new RoundRobin(),
    new ElasticsearchResurrect()
);

System details

  • ES-PHP client version : 8.5
ezimuel pushed a commit that referenced this issue Jan 30, 2023
Fix typo in the SimpleNodePool documentation (#1269 )
ezimuel pushed a commit that referenced this issue Jan 30, 2023
Fix typo in the SimpleNodePool documentation (#1269 )
ezimuel pushed a commit that referenced this issue Jan 30, 2023
Fix typo in the SimpleNodePool documentation (#1269 )
@ezimuel
Copy link
Contributor

ezimuel commented Feb 10, 2023

Solved in #1270

@ezimuel ezimuel closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants