SearchHitIterators and SearchResponseIterator helpers revised with new version #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this please |
|
I think the tests will be broken because of phpstan. 🥹 I could not find a way to ignore with comment or put that methods into interface. |
|
I ignored the lines from PHPStan. But, the test is broken again because of another reason. |
|
Ping @ezimuel |
|
I could not understand the tests that throw errors. As I remember, we got the same error before. |
…nside the interface
hkulekci
force-pushed
the
iterator-helpers
branch
from
009e28f
to
9efbbca
Compare
|
Thanks @hkulekci for the PR and sorry for the late reply. |
|
Thanks for merging 🕺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have problems related to the PHPStan check. I had already mentioned in issue #1301