Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Added the documentation for ELASTIC_CLIENT_URL_PLUS_AS_SPACE settings #1311

Merged
merged 5 commits into from Apr 20, 2023

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Apr 19, 2023

This PR adds the documentation for the usage of ELASTIC_CLIENT_URL_PLUS_AS_SPACE environmental variable. This resolve #1304

@ezimuel ezimuel added this to the 7.17.2 milestone Apr 19, 2023
@ezimuel ezimuel requested a review from szabosteve April 19, 2023 11:06
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions, mostly using present simple instead of future simple when possible for better understandability. Please take them or leave them.

docs/connecting.asciidoc Outdated Show resolved Hide resolved
docs/connecting.asciidoc Outdated Show resolved Hide resolved
docs/connecting.asciidoc Outdated Show resolved Hide resolved
docs/connecting.asciidoc Outdated Show resolved Hide resolved
ezimuel and others added 4 commits April 20, 2023 09:12
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
@ezimuel
Copy link
Contributor Author

ezimuel commented Apr 20, 2023

@szabosteve thanks a ton for the suggestions.

@ezimuel ezimuel merged commit 94cf43a into 7.17 Apr 20, 2023
13 of 15 checks passed
@ezimuel ezimuel deleted the doc/add-elastic-client-url-plus-as-space branch December 13, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants