Replace abandoned packages: ringphp, streams and phpstan-shim #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezimuel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #992 and also replace phpstan-shim abandoned package in dev.
The solution proposed is to use a fork of guzzlehttp/ringphp and guzzlehttp/streams. This is a temporary solution to continue to support these libraries until
elasticsearch-php 8.0.0. With this new major release, we will refactor all the HTTP transport layer removing the needs ofringphpandstreams.For
phpstan-shimwe replaced it with phpstan/phpstan using the procedure suggested here.The new
phpstanpackages removes also the need to have separate configuration file for PHP 7.1. I removed it in.travis.yaml. Moreover thanks to the newphpstan, I fixed and inconsistency inreturn $resultofTransport::resultOrFuture.