Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate 'elastic-transport-python' #1759

Merged
merged 6 commits into from Oct 18, 2021
Merged

Integrate 'elastic-transport-python' #1759

merged 6 commits into from Oct 18, 2021

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Oct 15, 2021

Integrates the development version of https://github.com/elastic/elastic-transport-python into the 8.0 branch.

  • Removes all transport/connection/pool classes from the package
  • Creates a new "BaseClient" which adds per-request configuration of transport options via .options().
  • Adds a _deprecated_options() function which is added as a part of API generation. This function resolves the deprecated per-request options via the new BaseClient.options() route.
  • Moves the product check into Elasticsearch._perform_request().
  • Moves the encoding of extra query parameters into Elasticsearch._perform_request()
  • Subclasses elastic_transport.JsonSerializer to add the additional encoding options for numpy/pandas/datetimes, etc
  • Refactors the exceptions to subclass elastic_transport.ApiError for API errors and to use elastic_transport.TransportError aliases to fill in exceptions that have been moved.
  • Documentation will likely fail due to removals, will handle this in a separate PR as more work needs to be done here.

TODO:

  • Handle api_key, basic_auth, bearer_auth, and deprecated http_auth.

@sethmlarson sethmlarson mentioned this pull request Oct 18, 2021
13 tasks
@sethmlarson sethmlarson merged commit 6462574 into main Oct 18, 2021
@sethmlarson sethmlarson deleted the elastic-transport branch October 18, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant