Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup and update code examples #2535

Merged
merged 5 commits into from
May 3, 2024

Conversation

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm wondering about two empty examples. If it's unexpected, I can dig further.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure your changes are kept the next time we generate examples, can you please add your changes to the generation script too?

@anniegale9538
Copy link
Contributor Author

To make sure your changes are kept the next time we generate examples, can you please add your changes to the generation script too?

How embarrassing 😓 added! Thanks for your patience, @pquentin

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Also, please continue your Friday night activities ;)

@pquentin pquentin merged commit f32878e into main May 3, 2024
17 of 18 checks passed
@pquentin pquentin deleted the annieh/add_setup_upgrade_es_code_examples branch May 3, 2024 15:09
github-actions bot pushed a commit that referenced this pull request May 3, 2024
* setup and update code examples

* adding generate-examples.py changes

* removing space generate-examples.py

* Fix formatting

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit f32878e)
pquentin pushed a commit that referenced this pull request May 17, 2024
* setup and update code examples

* adding generate-examples.py changes

* removing space generate-examples.py

* Fix formatting

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit f32878e)

Co-authored-by: Annie Hansen <annie.gale@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants