@ids is not an instance variable set anywhere

[tpitale]

But, there is a method called ids which collections the ids from hits: https://github.com/elasticsearch/elasticsearch-rails/blob/104f91f24ba8d3dc7629b0eaf058329dc2cdc08c/elasticsearch-model/lib/elasticsearch/model/response/records.rb#L33

[tpitale]

This use of @ids appears to be widespread in the README and in the examples folder.

[karmi]

Hey @tpitale, blast from the past! :) You're right, the @ids maybe worked at certain point in DM, but it doesn't anymore. Can you please sign the CLA so I can merge the patch?

(I understand this is a tiny change, but it's way easier for us to ask for the signature even for these... Thanks for understanding!)

[tpitale]

I'll sign as soon as I'm back in the States. Doesn't seem to work on mobile right now (just says preview not available). I should be back the end of next week.

On May 22, 2015, at 6:16 PM, Karel Minarik notifications@github.com wrote:

Hey @tpitale, blast from the past! :) You're right, the @ids maybe worked at certain point in DM, but it doesn't anymore. Can you please sign the CLA so I can merge the patch?

(I understand this is a tiny change, but it's way easier for us to ask for the signature even for these... Thanks for understanding!)

—
Reply to this email directly or view it on GitHub.

[karmi]

@tpitale Cool! Take your time and thanks! (Yeah, I think the service works correctly only on a computer...)

[tpitale]

Signed!

[tpitale]

I just re-signed the CLA. But the checks don't seem to update.