Avoid overriding previously defined custom options for lograge

[bolshakov]

Prevent overriding lograge.custom_options defined in main app.

[nilbus]

This looks good to me. Seems like a good fix for #749.

I like that it properly defers evaluation of the previous_lograge_custom_options lambda until the replacement config.lograge.custom_options lambda is evaluated.

[halilim]

One thing to note: custom_options can be a Hash.

I think a better option would be Lograge supporting an array/custom object that supports appending/prepending to it (edit: I've created roidrage/lograge#236 to track the suggestion).

[nilbus]

Good catch @halilim. This assumes that previous_lograge_custom_options responds to call, which it won't when it's a Hash.

[bolshakov]

I'm absolutely agree that having multiple custom_options is more flexible. Currently I have the following fix in my application.rb and it works an applications side

  class Application < Rails::Application
    # Load it after ELC's lograge engine to fix overriding custom_options
    # @see https://github.com/elastic/elasticsearch-rails/issues/749
    initializer 'custom_lograge', after: 'elasticsearch.lograge' do
      previous_lograge_custom_options = config.lograge.custom_options
      config.lograge.custom_options = lambda do |event|
        previous_lograge_custom_options.call(event).merge(
          user: event.payload[:user],
        )
      end
    end
  end

I updated this PR as well to support hash in custom_options.

[leiz-me]

When will this PR get into the master or any release version that may update with bundler?

[bolshakov]

@nilbus I tried to sign CLA, but it says browser's cookies are disabled (this is not true), so the form doesn't work for me.

[estolfo]

@bolshakov can you try signing the CLA again please? Thanks

[bolshakov]

Unfortunately it still says I have disabled cookies.

[estolfo]

Would you mind trying in a different browser?

[bolshakov]

I managed to open the agreement and unfortunately can't assess this legal document and possible consequences for me. So, I'm closing this PR.