Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ruby 2.7 deprecation warning on find_in_batches #937

Merged
merged 1 commit into from May 11, 2020

Conversation

chrisyuska
Copy link
Contributor

Calling Model#import with Ruby 2.7 results in a deprecation warning due to passing options into find_in_batches as keyword arguments without explicitly stating so:

.../activerecord-6.0.3/lib/active_record/querying.rb:21: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
.../activerecord-6.0.3/lib/active_record/relation/batches.rb:126: warning: The called method `find_in_batches' is defined here

@cla-checker-service
Copy link

cla-checker-service bot commented May 8, 2020

💚 CLA has been signed

@chrisyuska
Copy link
Contributor Author

❌ Author of the following commits did not sign a Contributor Agreement:
20c3cd7

Please, read and sign the above mentioned agreement if you want to contribute to this project

Signed!

@picandocodigo
Copy link
Member

@chrisyuska Hi, thanks for this contribution! It looks like the checker didn't find your signature. Did you use the same e-mail for it than the one on your GitHub account?

@chrisyuska
Copy link
Contributor Author

chrisyuska commented May 11, 2020

@chrisyuska Hi, thanks for this contribution! It looks like the checker didn't find your signature. Did you use the same e-mail for it than the one on your GitHub account?

That's odd. I did use the primary email on my GitHub account. I re-signed again just now in case I had a typo on the earlier one. Let me know if there's anything else I can do to help the checker find it.

Edit: Looks like it found it now!

@picandocodigo
Copy link
Member

That's it! Thanks again!

@picandocodigo picandocodigo merged commit 80f8590 into elastic:master May 11, 2020
@chrisyuska chrisyuska deleted the hotfix/ruby-2.7-support branch May 13, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants