Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable elasticsearch-transport v7 to use Faraday >=2 #2228

Closed
bkmgit opened this issue Oct 14, 2023 · 1 comment
Closed

Enable elasticsearch-transport v7 to use Faraday >=2 #2228

bkmgit opened this issue Oct 14, 2023 · 1 comment
Labels
feature request Feature requests

Comments

@bkmgit
Copy link

bkmgit commented Oct 14, 2023

Is your feature request related to a problem? Please describe.
Faraday 2 has been available for some time. It would be helpful to enable elasticsearch transport
to use it rather than be limited to Faraday >~ 1

Describe the solution you'd like
Enable use of both Faraday 1 and Faraday 2

Describe alternatives you've considered
Could be left as is if not possible or very difficult. Willing to see if this can be implemented.

Additional context
Feature has been added to elastic-transport-ruby but would be helpful to have it for older maintained versions
#1805
@bkmgit bkmgit added the feature request Feature requests label Oct 14, 2023
santiagorodriguez96 added a commit to santiagorodriguez96/elasticsearch-ruby that referenced this issue Oct 24, 2023
@santiagorodriguez96
Enable elasticsearch-transport v7 to use Faraday >=2
0d12952 
Attempts to close elastic#2228.
All credit for this goes to @picandocodigo, as these are the same changes
made in elastic/elastic-transport-ruby#30 but for version 7.17 of
`elastic-transport` – I just copy-pasted that code over.
@santiagorodriguez96 santiagorodriguez96 mentioned this issue Oct 24, 2023
Merged
picandocodigo pushed a commit that referenced this issue Nov 6, 2023
@santiagorodriguez96 @picandocodigo
Enable elasticsearch-transport v7 to use Faraday >=2
e7e7261 
Attempts to close #2228.
All credit for this goes to @picandocodigo, as these are the same changes
made in elastic/elastic-transport-ruby#30 but for version 7.17 of
`elastic-transport` – I just copy-pasted that code over.
@picandocodigo
Copy link
Member

Hi @bkmgit,
elasticsearch 7.17.10 has been released with support for Faraday 2 from:

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@picandocodigo @bkmgit