Problem with scripted update - "params" are ignored

[madebydna]

I'm trying to do a scripted partial update but my params are being ignored, or they are evaluated as null:

body = {
  script: "if (!ctx._source.containsKey(\"title_akas\")) { ctx._source.title_akas = [] }
    ctx._source.title_akas.add(params.aka)",
  params: {
    aka: { text: "New Title AKA" }
  },
  lang: "painless"
}

client = Elasticsearch::Client.new(host: Rails.application.secrets.es_url, log: false)
client.update index: "test", type: "program", id: "1234", body: body

The result of the operation is that a null title_akas is added:

"title_akas": [
   null
],...

title_akas is a nested field in the index:

  "title_akas": {
       "type": "nested",
       "properties": {
       "text": {
           "type": "text"
       }
    }
  },

The same scripted update works via the console:

POST test/program/1234/_update
{
  "script": {
    "inline": "if (!ctx._source.containsKey(\"title_akas\")) { ctx._source.title_akas = [] } ctx._source.title_akas.add(params.aka)",
    "lang": "painless",
    "params": {
      "aka": {
        "text": "New Title AKA"
      }
    }
  }
}

[felipeelias]

The script should be a hash, the same way it is done via console

body = {
  script: {
    source: "if (!ctx._source.containsKey(\"title_akas\")) { ctx._source.title_akas = [] } ctx._source.title_akas.add(params.aka)",
    params: {
      aka: { text: "New Title AKA" }
    },
    lang: "painless"
  }
}

[madebydna]

@felipeelias thanks, that worked! I was following the example in the documentation that suggested that the script key in the body hash is a string.

 # @example Add a tag to document `tags` property using a `script`
 #
 #     client.update index: 'myindex', type: 'mytype', id: '1',
 #                   body: { script: 'ctx._source.tags += tag', params: { tag: 'x' } }

[karmi]

Hi @madebydna, yes, @felipeelias is right, the format has changed, but the inline documentation has not been updated.

I've updated the example, it should be:

client.update index: 'myindex', type: 'mytype', id: '1',
                       body: { script: { source: 'ctx._source.tags.add(params.tag)', params: { tag: 'x' } } }

Thanks for bringing it to my attention!