feat(helpers): Throw an explicit error when asStream is used with bul…

…k helper (#37)

Porting elastic/elasticsearch-js@4269197

src/helpers.ts

@@ -524,6 +524,8 @@ export default class Helpers {
    * @return {object} The possible operations to run with the datasource.
    */
   bulk<TDocument = unknown> (options: BulkHelperOptions<TDocument>, reqOptions: TransportRequestOptions = {}): BulkHelper<TDocument> {
+    assert(!(reqOptions.asStream ?? false), 'bulk helper: the asStream request option is not supported')
+
     const client = this[kClient]
     const { serializer } = client
     if (this[kMetaHeader] !== null) {

test/unit/helpers/bulk.test.ts

@@ -17,6 +17,7 @@
  * under the License.
  */
 
+import { AssertionError } from 'assert'
 import * as http from 'http'
 import { createReadStream } from 'fs'
 import { join } from 'path'
@@ -1161,6 +1162,36 @@ test('transport options', t => {
     })
   })
 
+  t.test('Should not allow asStream request option', async t => {
+    t.plan(2)
+
+    const client = new Client({
+      node: 'http://localhost:9200',
+    })
+
+    try {
+      await client.helpers.bulk({
+        datasource: dataset.slice(),
+        flushBytes: 1,
+        concurrency: 1,
+        onDocument (doc) {
+          return { index: { _index: 'test' } }
+        },
+        onDrop (doc) {
+          t.fail('This should never be called')
+        },
+      }, {
+        headers: {
+          foo: 'bar'
+        },
+        asStream: true,
+      })
+    } catch (err: any) {
+      t.ok(err instanceof AssertionError)
+      t.equal(err.message, 'bulk helper: the asStream request option is not supported')
+    }
+  })
+
   t.end()
 })