Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MultiSearchItem.status optional #1320

Merged
merged 1 commit into from Jan 25, 2022
Merged

Make MultiSearchItem.status optional #1320

merged 1 commit into from Jan 25, 2022

Conversation

swallez
Copy link
Member

@swallez swallez commented Jan 25, 2022

The MultiSearchItem.status property is always returned in multisearch responses but is missing from multisearch-template responses.

This should be considered as an inconsistency/bug in the ES API, and this PR fixes it by making status optional rather than creating a separate type for multisearch-template responses.

Reported in elastic/elasticsearch-java#110

@swallez swallez requested a review from delvedor January 25, 2022 09:09
@philkra philkra mentioned this pull request Jan 25, 2022
Closed
philkra
philkra approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I closed #1178 as addresses the same missing property but differently

@swallez
Copy link
Member Author

swallez commented Jan 25, 2022

Thanks @philkra. Re-reading my comments in #1178 I realize that I only looked at the multisearch response and not the multisearch template response, because I (wrongly) assumed that they were the same 🤷

@swallez swallez mentioned this pull request Jan 25, 2022
Closed
@swallez
Copy link
Member Author

swallez commented Jan 25, 2022

Opened an issue in Elasticsearch: elastic/elasticsearch#83029

@swallez swallez merged commit 92ee65e into main Jan 25, 2022
@swallez swallez deleted the fix-mtemplate-search-response branch January 25, 2022 11:19
github-actions bot pushed a commit that referenced this pull request Jan 25, 2022
@swallez @github-actions
Make MultiSearchItem.status optional (#1320)
276a606
@github-actions github-actions bot mentioned this pull request Jan 25, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Jan 25, 2022
@swallez @github-actions
Make MultiSearchItem.status optional (#1320)
7c9ee42
@github-actions github-actions bot mentioned this pull request Jan 25, 2022
Merged
swallez added a commit that referenced this pull request Jan 25, 2022
@github-actions @swallez
Make MultiSearchItem.status optional (#1320) (#1321)
4cf59cb 
Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
swallez added a commit that referenced this pull request Jan 25, 2022
@github-actions @swallez
Make MultiSearchItem.status optional (#1320) (#1322)
f0ae86f 
Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
@swallez swallez mentioned this pull request Jan 25, 2022
Closed
@swallez swallez mentioned this pull request May 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anaethelion Anaethelion Anaethelion approved these changes

@philkra philkra philkra approved these changes

@delvedor delvedor Awaiting requested review from delvedor

Assignees
No one assigned
Labels
backport 7.17 backport 8.0 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swallez @Anaethelion @philkra