Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synonyms/put_synonym_rule body #2407

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Feb 8, 2024

synonyms is not a list, but a string in Solr format.

synonyms is not a list, but a string in Solr format.
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
synonyms.put_synonym_rule 🔴 4/4 3/4

You can validate this API yourself by using the make validate target.

Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@pquentin pquentin merged commit 90b0967 into main Feb 8, 2024
8 checks passed
@pquentin pquentin deleted the fix-put-synonym-rule-body branch February 8, 2024 10:07
Copy link
Contributor

github-actions bot commented Feb 8, 2024

The backport to 8.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.11 8.11
# Navigate to the new working tree
cd .worktrees/backport-8.11
# Create a new branch
git switch --create backport-2407-to-8.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 90b09673b22aa4537a2339470dc123d03f167f3b
# Push it to GitHub
git push --set-upstream origin backport-2407-to-8.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.11

Then, create a pull request where the base branch is 8.11 and the compare/head branch is backport-2407-to-8.11.

github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
synonyms is not a list, but a string in Solr format.

(cherry picked from commit 90b0967)
pquentin added a commit that referenced this pull request Feb 8, 2024
synonyms is not a list, but a string in Solr format.

(cherry picked from commit 90b0967)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Feb 8, 2024
synonyms is not a list, but a string in Solr format.

(cherry picked from commit 90b0967)
@pquentin
Copy link
Member Author

pquentin commented Feb 8, 2024

The backport to 8.11 failed:

Opened #2409, the conflict was output/openapi/elasticsearch-serverless-openapi.json which isn't in 8.11.

pquentin added a commit that referenced this pull request Feb 8, 2024
synonyms is not a list, but a string in Solr format.

(cherry picked from commit 90b0967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants