Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed various template related requests #2488

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Apr 5, 2024

  1. PutComponentTemplate (/_component_template/{name}) :
  2. PutTemplate (/_template/{name}), named PutIndexTemplate in the server code :
  3. PutIndexTemplate (/_index_template/{name}), named PutComposableIndexTemplate in the server code :

bonus: IndicesSimulateTemplateRequest was also missing deprecated
bonus 2: priority is a long, not an int

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cluster.put_component_template 🔴 19/25 24/25
indices.put_index_template 🔴 49/52 51/52
indices.put_template 🔴 43/49 48/49
indices.simulate_template 🔴 4/5 3/5

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants