Fix: allow (re)setting the current catalog #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows the application set the value of the current catalog attribute, in case this value is the same with what the driver had previously returned for this attribute. This currently only works if the attribute had been retrieved before setting, on the same connection; specifically, it won't work when this would be set as a pre-connection attribute.
droberts195
approved these changes
Feb 28, 2020
test/test_driverconnect.cc
Outdated
| @@ -7,6 +7,11 @@ | |||
| #include <gtest/gtest.h> | |||
| #include "connected_dbc.h" | |||
|
|
|||
| /* */ | |||
- remove empty comment Also apply change that was (somehow) not caught by the hooked formatter previously.
bpintea
added a commit
that referenced
this pull request
Feb 28, 2020
* allow (re)setting the current catalog This commit allows the application set the value of the current catalog attribute, in case this value is the same with what the driver had previously returned for this attribute. This currently only works if the attribute had been retrieved before setting, on the same connection; specifically, it won't work when this would be set as a pre-connection attribute. (cherry picked from commit 279c485)
bpintea
added a commit
that referenced
this pull request
Feb 28, 2020
* allow (re)setting the current catalog This commit allows the application set the value of the current catalog attribute, in case this value is the same with what the driver had previously returned for this attribute. This currently only works if the attribute had been retrieved before setting, on the same connection; specifically, it won't work when this would be set as a pre-connection attribute. (cherry picked from commit 279c485)
bpintea
added a commit
that referenced
this pull request
Feb 28, 2020
* allow (re)setting the current catalog This commit allows the application set the value of the current catalog attribute, in case this value is the same with what the driver had previously returned for this attribute. This currently only works if the attribute had been retrieved before setting, on the same connection; specifically, it won't work when this would be set as a pre-connection attribute. (cherry picked from commit 279c485)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the application set the value of the current catalog attribute, in case this value is the same with what the driver had previously returned for this attribute.
Although Elasticsearch/SQL has no proper catalog support currently, this case should be supported as a safe use of the API.
This currently only works if the attribute had been retrieved before setting, on the same connection; specifically, it won't work when this would be set as a pre-connection attribute.
Closes #211.