Server version check #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver will now report the qualifer in the version string.
- update the defines reporting data source's scalar capabilities.
The server and driver versions will be checked to match. It's thus safe to report own version.
Check if server's and driver's versions are in sync. Refuse connection if they aren't.
Closed
droberts195
approved these changes
Dec 18, 2018
driver/catalogue.c
Outdated
| @@ -48,7 +48,7 @@ static SQLRETURN fake_answer(SQLHSTMT hstmt, const char *src, size_t cnt) | |||
| { | |||
| char *dup; | |||
|
|
|||
| if (! (dup = strdup(src))) { | |||
| if (! (dup = _strdup(src))) { | |||
There was a problem hiding this comment.
This caters to Microsoft’s pedantry, but will make porting to Linux harder. I think an alternative is to /D_CRT_NONSTDC_NO_DEPRECATE.
driver/connect.c
Outdated
| static const wchar_t err_msg_fmt[] = L"Version mismatch between server (" | ||
| WPFWP_LDESC ") and driver (" WPFWP_LDESC "). Please use a driver whose" | ||
| " version matches that of your server."; | ||
| /* 32: max lenght of the version strings for which the explicit message |
- also fix a comment typo
|
Thank you for the prompt review! Comments addressed. |
bpintea
added a commit
that referenced
this pull request
Dec 18, 2018
* append version qualifer to version string The driver will now report the qualifer in the version string. * update advertised function caps - update the defines reporting data source's scalar capabilities. * report own version when app is asking for DB ver. The server and driver versions will be checked to match. It's thus safe to report own version. * fix compilation warnings (x86) * check server's version against own Check if server's and driver's versions are in sync. Refuse connection if they aren't. * revert to deprecated strdup, add warning silencer - also fix a comment typo (cherry picked from commit 1c276a5)
bpintea
added
>feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds version checks of version strings.
If Elasticsearch'es version doesn't match own version, the connection is refused.
It also updates the reporting of the scalar functions the data source supports.