Skip to content

Commit

Permalink
remove TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
javanna committed Dec 12, 2018
1 parent 12deca8 commit 03e4965
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public final class SearchHits implements Streamable, ToXContentFragment, Iterabl

public static SearchHits empty() {
// We shouldn't use static final instance, since that could directly be returned by native transport clients
return new SearchHits(EMPTY, new TotalHits(0, Relation.EQUAL_TO), 0, null, null, null);
return new SearchHits(EMPTY, new TotalHits(0, Relation.EQUAL_TO), 0);
}

public static final SearchHit[] EMPTY = new SearchHit[0];
Expand All @@ -69,10 +69,6 @@ public static SearchHits empty() {

}

//TODO look for other users of the old constructor!!!

//TODO we may want to remove this constructor and replace it with the new one:
// such change causes a lot of noise, probably wise to make it as a followup
public SearchHits(SearchHit[] hits, @Nullable TotalHits totalHits, float maxScore) {
this(hits, totalHits, maxScore, null, null, null);
}
Expand Down

0 comments on commit 03e4965

Please sign in to comment.