Skip to content

Commit

Permalink
Drop faulty assertion in TransportService (#86843)
Browse files Browse the repository at this point in the history
We introduced an assertion in #85131 to check the assumption that there
are no pending non-local response handlers when the `TransportService`
shuts down. We later discovered that this assertion rarely tripped,
which we fixed in #86315, but that fix did not go into 8.2 so there are
still rare failures on this branch. This commit drops the faulty
assertion in 8.2.

Relates #86293
  • Loading branch information
DaveCTurner committed May 17, 2022
1 parent 6f43380 commit 26b30d7
Showing 1 changed file with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,6 @@ protected void doStop() {
final TransportResponseHandler<?> handler = holderToNotify.handler();
final var targetNode = holderToNotify.connection().getNode();

// Assertion only holds for TcpTransport only because other transports (used in tests) may not implement the proper
// close-connection behaviour. TODO fix this.
assert transport instanceof TcpTransport == false || targetNode.equals(localNode) : targetNode + " vs " + localNode;

final var exception = new SendRequestTransportException(
targetNode,
holderToNotify.action(),
Expand Down

0 comments on commit 26b30d7

Please sign in to comment.