Release time series aggegations as tech preview (#93546)

Make time_series aggregation and rate aggregation (on counter fields) available without using the time series feature flag. This change makes these aggregations available as tech preview.
elastic · Feb 7, 2023 · 33c9636 · 33c9636
1 parent 815e6d7
commit 33c9636
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 15 deletions.
diff --git a/docs/changelog/93546.yaml b/docs/changelog/93546.yaml
@@ -0,0 +1,15 @@
+pr: 93546
+summary: Release time_series and rate (on counter fields) aggegations as tech preview
+area: TSDB
+type: feature
+issues: []
+highlight:
+  title: Release time_series and rate (on counter fields) aggegations as tech preview
+  body: |-
+    Make `time_series` aggregation and `rate` aggregation (on counter
+    fields) available without using the time series feature flag. This
+    change makes these aggregations available as tech preview.
+
+    Currently there is no documentation about the `time_series` aggregation.
+    This will be added in a followup change.
+  notable: true
diff --git a/modules/aggregations/src/main/java/org/elasticsearch/aggregations/AggregationsPlugin.java b/modules/aggregations/src/main/java/org/elasticsearch/aggregations/AggregationsPlugin.java
@@ -23,7 +23,6 @@
 import org.elasticsearch.aggregations.pipeline.DerivativePipelineAggregationBuilder;
 import org.elasticsearch.aggregations.pipeline.MovFnPipelineAggregationBuilder;
 import org.elasticsearch.aggregations.pipeline.MovingFunctionScript;
-import org.elasticsearch.index.IndexSettings;
 import org.elasticsearch.plugins.Plugin;
 import org.elasticsearch.plugins.ScriptPlugin;
 import org.elasticsearch.plugins.SearchPlugin;
@@ -55,15 +54,10 @@ public List<AggregationSpec> getAggregations() {
             new AggregationSpec(MatrixStatsAggregationBuilder.NAME, MatrixStatsAggregationBuilder::new, new MatrixStatsParser())
                 .addResultReader(InternalMatrixStats::new)
         );
-        if (IndexSettings.isTimeSeriesModeEnabled()) {
-            specs.add(
-                new AggregationSpec(
-                    TimeSeriesAggregationBuilder.NAME,
-                    TimeSeriesAggregationBuilder::new,
-                    TimeSeriesAggregationBuilder.PARSER
-                ).addResultReader(InternalTimeSeries::new)
-            );
-        }
+        specs.add(
+            new AggregationSpec(TimeSeriesAggregationBuilder.NAME, TimeSeriesAggregationBuilder::new, TimeSeriesAggregationBuilder.PARSER)
+                .addResultReader(InternalTimeSeries::new)
+        );
         return List.copyOf(specs);
     }
 

diff --git a/server/src/main/java/org/elasticsearch/search/SearchService.java b/server/src/main/java/org/elasticsearch/search/SearchService.java
@@ -1236,7 +1236,7 @@ private void parseSource(DefaultSearchContext context, SearchSourceBuilder sourc
                 context::isCancelled,
                 context::buildFilteredQuery,
                 enableRewriteAggsToFilterByFilter,
-                IndexSettings.isTimeSeriesModeEnabled() && source.aggregations().isInSortOrderExecutionRequired()
+                source.aggregations().isInSortOrderExecutionRequired()
             );
             context.addReleasable(aggContext);
             try {

diff --git a/x-pack/plugin/analytics/src/main/java/org/elasticsearch/xpack/analytics/AnalyticsPlugin.java b/x-pack/plugin/analytics/src/main/java/org/elasticsearch/xpack/analytics/AnalyticsPlugin.java
@@ -16,7 +16,6 @@
 import org.elasticsearch.common.settings.Setting;
 import org.elasticsearch.env.Environment;
 import org.elasticsearch.env.NodeEnvironment;
-import org.elasticsearch.index.IndexSettings;
 import org.elasticsearch.index.mapper.Mapper;
 import org.elasticsearch.plugins.ActionPlugin;
 import org.elasticsearch.plugins.MapperPlugin;
@@ -136,9 +135,7 @@ private AggregationSpec rateAggregation() {
             RateAggregationBuilder::new,
             usage.track(AnalyticsStatsAction.Item.RATE, RateAggregationBuilder.PARSER)
         ).addResultReader(InternalRate::new).setAggregatorRegistrar(RateAggregationBuilder::registerAggregators);
-        if (IndexSettings.isTimeSeriesModeEnabled()) {
-            rate.addResultReader(InternalResetTrackingRate.NAME, InternalResetTrackingRate::new);
-        }
+        rate.addResultReader(InternalResetTrackingRate.NAME, InternalResetTrackingRate::new);
         return rate;
     }