-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ESQL: Test expression translators for binary comparisons and ranges (#…
…108609) Part of #106679 Add tests for our query translators for binary comparisons and ranges. Turns out, our query translators, which we use whenever we push down filters to Lucene, have only partial test coverage in some of the LocalPhysicalOptimzerTests. We need to expand test coverage, so this sets up the necessary plumbing and adds the first query translator spec tests.
- Loading branch information
1 parent
8a43665
commit 5108f6b
Showing
4 changed files
with
265 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
...lugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/TestPlannerOptimizer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.xpack.esql.optimizer; | ||
|
|
||
| import org.elasticsearch.xpack.esql.EsqlTestUtils; | ||
| import org.elasticsearch.xpack.esql.analysis.Analyzer; | ||
| import org.elasticsearch.xpack.esql.expression.function.EsqlFunctionRegistry; | ||
| import org.elasticsearch.xpack.esql.parser.EsqlParser; | ||
| import org.elasticsearch.xpack.esql.plan.physical.EstimatesRowSize; | ||
| import org.elasticsearch.xpack.esql.plan.physical.PhysicalPlan; | ||
| import org.elasticsearch.xpack.esql.planner.Mapper; | ||
| import org.elasticsearch.xpack.esql.planner.PlannerUtils; | ||
| import org.elasticsearch.xpack.esql.session.EsqlConfiguration; | ||
| import org.elasticsearch.xpack.esql.stats.SearchStats; | ||
|
|
||
| public class TestPlannerOptimizer { | ||
| private final EsqlParser parser; | ||
| private final Analyzer analyzer; | ||
| private final LogicalPlanOptimizer logicalOptimizer; | ||
| private final PhysicalPlanOptimizer physicalPlanOptimizer; | ||
| private final EsqlFunctionRegistry functionRegistry; | ||
| private final Mapper mapper; | ||
| private final EsqlConfiguration config; | ||
|
|
||
| public TestPlannerOptimizer(EsqlConfiguration config, Analyzer analyzer) { | ||
| this.analyzer = analyzer; | ||
| this.config = config; | ||
|
|
||
| parser = new EsqlParser(); | ||
| logicalOptimizer = new LogicalPlanOptimizer(new LogicalOptimizerContext(config)); | ||
| physicalPlanOptimizer = new PhysicalPlanOptimizer(new PhysicalOptimizerContext(config)); | ||
| functionRegistry = new EsqlFunctionRegistry(); | ||
| mapper = new Mapper(functionRegistry); | ||
| } | ||
|
|
||
| public PhysicalPlan plan(String query) { | ||
| return plan(query, EsqlTestUtils.TEST_SEARCH_STATS); | ||
| } | ||
|
|
||
| public PhysicalPlan plan(String query, SearchStats stats) { | ||
| return plan(query, stats, analyzer); | ||
| } | ||
|
|
||
| public PhysicalPlan plan(String query, SearchStats stats, Analyzer analyzer) { | ||
| var physical = optimizedPlan(physicalPlan(query, analyzer), stats); | ||
| return physical; | ||
| } | ||
|
|
||
| private PhysicalPlan optimizedPlan(PhysicalPlan plan, SearchStats searchStats) { | ||
| // System.out.println("* Physical Before\n" + plan); | ||
| var physicalPlan = EstimatesRowSize.estimateRowSize(0, physicalPlanOptimizer.optimize(plan)); | ||
| // System.out.println("* Physical After\n" + physicalPlan); | ||
| // the real execution breaks the plan at the exchange and then decouples the plan | ||
| // this is of no use in the unit tests, which checks the plan as a whole instead of each | ||
| // individually hence why here the plan is kept as is | ||
|
|
||
| var logicalTestOptimizer = new LocalLogicalPlanOptimizer(new LocalLogicalOptimizerContext(config, searchStats)); | ||
| var physicalTestOptimizer = new TestLocalPhysicalPlanOptimizer(new LocalPhysicalOptimizerContext(config, searchStats), true); | ||
| var l = PlannerUtils.localPlan(physicalPlan, logicalTestOptimizer, physicalTestOptimizer); | ||
|
|
||
| // handle local reduction alignment | ||
| l = PhysicalPlanOptimizerTests.localRelationshipAlignment(l); | ||
|
|
||
| // System.out.println("* Localized DataNode Plan\n" + l); | ||
| return l; | ||
| } | ||
|
|
||
| private PhysicalPlan physicalPlan(String query, Analyzer analyzer) { | ||
| var logical = logicalOptimizer.optimize(analyzer.analyze(parser.createStatement(query))); | ||
| // System.out.println("Logical\n" + logical); | ||
| var physical = mapper.map(logical); | ||
| return physical; | ||
| } | ||
| } |
Oops, something went wrong.