-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure tasks preserve versions in
MasterService
(#109850)
`ClusterState#version`, `Metadata#version` and `RoutingTable#version` are all managed solely by the `MasterService`, in the sense that it's a definite bug for the cluster state update task executor to meddle with them. Today if we encounter such a bug then we try and publish the resulting state anyway, which hopefully fails (triggering a master election) but it may in theory succeed (potentially reverting older cluster state updates). Neither is a particularly good outcome. With this commit we add a check for consistency of these version numbers during the cluster state computation and fail the state update without a master failover if a discrepancy is found. It also fixes a super-subtle bug in `TransportMigrateToDataTiersAction` that can muck up these version numbers.
- Loading branch information
1 parent
c8da581
commit 5aa9f44
Showing
5 changed files
with
121 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
pr: 109850 | ||
summary: Ensure tasks preserve versions in `MasterService` | ||
area: Cluster Coordination | ||
type: bug | ||
issues: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters