Skip to content

Commit

Permalink
Added support for acknowledgement from other nodes in open/close inde…
Browse files Browse the repository at this point in the history
…x api

The open/close index api now waits for an acknowledgement from all the other nodes before returning its response, till the timeout (configurable, default 10 secs) expires. The returned acknowledged flag reflects whether the cluster state change was acknowledged by all the nodes or the timeout expired before.

Closes #3400
  • Loading branch information
javanna committed Jul 29, 2013
1 parent ca0778e commit 6ab76a5
Show file tree
Hide file tree
Showing 9 changed files with 491 additions and 15 deletions.
Expand Up @@ -44,7 +44,7 @@ public class CloseIndexRequest extends MasterNodeOperationRequest<CloseIndexRequ
}

/**
* Constructs a new delete index request for the specified index.
* Constructs a new close index request for the specified index.
*/
public CloseIndexRequest(String index) {
this.index = index;
Expand Down Expand Up @@ -72,15 +72,15 @@ public CloseIndexRequest index(String index) {
}

/**
* Timeout to wait for the index deletion to be acknowledged by current cluster nodes. Defaults
* Timeout to wait for the index closure to be acknowledged by current cluster nodes. Defaults
* to <tt>10s</tt>.
*/
TimeValue timeout() {
return timeout;
}

/**
* Timeout to wait for the index deletion to be acknowledged by current cluster nodes. Defaults
* Timeout to wait for the index closure to be acknowledged by current cluster nodes. Defaults
* to <tt>10s</tt>.
*/
public CloseIndexRequest timeout(TimeValue timeout) {
Expand All @@ -89,7 +89,7 @@ public CloseIndexRequest timeout(TimeValue timeout) {
}

/**
* Timeout to wait for the index deletion to be acknowledged by current cluster nodes. Defaults
* Timeout to wait for the index closure to be acknowledged by current cluster nodes. Defaults
* to <tt>10s</tt>.
*/
public CloseIndexRequest timeout(String timeout) {
Expand Down
Expand Up @@ -44,7 +44,7 @@ public class OpenIndexRequest extends MasterNodeOperationRequest<OpenIndexReques
}

/**
* Constructs a new delete index request for the specified index.
* Constructs a new open index request for the specified index.
*/
public OpenIndexRequest(String index) {
this.index = index;
Expand Down Expand Up @@ -72,15 +72,15 @@ public OpenIndexRequest index(String index) {
}

/**
* Timeout to wait for the index deletion to be acknowledged by current cluster nodes. Defaults
* Timeout to wait for the index opening to be acknowledged by current cluster nodes. Defaults
* to <tt>10s</tt>.
*/
TimeValue timeout() {
return timeout;
}

/**
* Timeout to wait for the index deletion to be acknowledged by current cluster nodes. Defaults
* Timeout to wait for the index opening to be acknowledged by current cluster nodes. Defaults
* to <tt>10s</tt>.
*/
public OpenIndexRequest timeout(TimeValue timeout) {
Expand All @@ -89,7 +89,7 @@ public OpenIndexRequest timeout(TimeValue timeout) {
}

/**
* Timeout to wait for the index deletion to be acknowledged by current cluster nodes. Defaults
* Timeout to wait for the index opening to be acknowledged by current cluster nodes. Defaults
* to <tt>10s</tt>.
*/
public OpenIndexRequest timeout(String timeout) {
Expand Down
22 changes: 21 additions & 1 deletion src/main/java/org/elasticsearch/cluster/ClusterChangedEvent.java
Expand Up @@ -20,12 +20,14 @@
package org.elasticsearch.cluster;

import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Lists;
import org.elasticsearch.cluster.metadata.IndexMetaData;
import org.elasticsearch.cluster.metadata.MetaData;
import org.elasticsearch.cluster.node.DiscoveryNodes;

import java.util.List;
import java.util.Map;

/**
*
Expand Down Expand Up @@ -161,4 +163,22 @@ public boolean nodesAdded() {
public boolean nodesChanged() {
return nodesRemoved() || nodesAdded();
}
}

public boolean indicesStateChanged() {
if (metaDataChanged()) {
ImmutableMap<String,IndexMetaData> indices = state.metaData().indices();
ImmutableMap<String,IndexMetaData> previousIndices = previousState.metaData().indices();

for (Map.Entry<String, IndexMetaData> entry : indices.entrySet()) {
IndexMetaData indexMetaData = entry.getValue();
IndexMetaData previousIndexMetaData = previousIndices.get(entry.getKey());
if (previousIndexMetaData != null
&& indexMetaData.state() != previousIndexMetaData.state()) {
return true;
}
}
}

return false;
}
}
1 change: 1 addition & 0 deletions src/main/java/org/elasticsearch/cluster/ClusterModule.java
Expand Up @@ -77,5 +77,6 @@ protected void configure() {
bind(NodeMappingRefreshAction.class).asEagerSingleton();
bind(MappingUpdatedAction.class).asEagerSingleton();
bind(NodeAliasesUpdatedAction.class).asEagerSingleton();
bind(NodeIndicesStateUpdatedAction.class).asEagerSingleton();
}
}
@@ -0,0 +1,154 @@
/*
* Licensed to ElasticSearch and Shay Banon under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. ElasticSearch licenses this
* file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/

package org.elasticsearch.cluster.action.index;

import org.elasticsearch.ElasticSearchException;
import org.elasticsearch.cluster.ClusterService;
import org.elasticsearch.cluster.node.DiscoveryNodes;
import org.elasticsearch.common.component.AbstractComponent;
import org.elasticsearch.common.inject.Inject;
import org.elasticsearch.common.io.stream.StreamInput;
import org.elasticsearch.common.io.stream.StreamOutput;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.common.unit.TimeValue;
import org.elasticsearch.threadpool.ThreadPool;
import org.elasticsearch.transport.*;

import java.io.IOException;
import java.util.List;
import java.util.concurrent.CopyOnWriteArrayList;

public class NodeIndicesStateUpdatedAction extends AbstractComponent {

private final ThreadPool threadPool;

private final TransportService transportService;

private final ClusterService clusterService;

private final List<Listener> listeners = new CopyOnWriteArrayList<Listener>();

@Inject
public NodeIndicesStateUpdatedAction(Settings settings, ThreadPool threadPool, TransportService transportService, ClusterService clusterService) {
super(settings);
this.threadPool = threadPool;
this.transportService = transportService;
this.clusterService = clusterService;
transportService.registerHandler(NodeIndexStateUpdatedTransportHandler.ACTION, new NodeIndexStateUpdatedTransportHandler());
}

public void add(final Listener listener, TimeValue timeout) {
listeners.add(listener);
threadPool.schedule(timeout, ThreadPool.Names.GENERIC, new Runnable() {
@Override
public void run() {
boolean removed = listeners.remove(listener);
if (removed) {
listener.onTimeout();
}
}
});
}

public void remove(Listener listener) {
listeners.remove(listener);
}

public void nodeIndexStateUpdated(final NodeIndexStateUpdatedResponse response) throws ElasticSearchException {
DiscoveryNodes nodes = clusterService.state().nodes();
if (nodes.localNodeMaster()) {
threadPool.generic().execute(new Runnable() {
@Override
public void run() {
innerNodeIndexStateUpdated(response);
}
});
} else {
transportService.sendRequest(clusterService.state().nodes().masterNode(),
NodeIndexStateUpdatedTransportHandler.ACTION, response, EmptyTransportResponseHandler.INSTANCE_SAME);
}
}

private void innerNodeIndexStateUpdated(NodeIndexStateUpdatedResponse response) {
for (Listener listener : listeners) {
listener.onIndexStateUpdated(response);
}
}

private class NodeIndexStateUpdatedTransportHandler extends BaseTransportRequestHandler<NodeIndexStateUpdatedResponse> {

static final String ACTION = "cluster/nodeIndexStateUpdated";

@Override
public NodeIndexStateUpdatedResponse newInstance() {
return new NodeIndexStateUpdatedResponse();
}

@Override
public void messageReceived(NodeIndexStateUpdatedResponse response, TransportChannel channel) throws Exception {
innerNodeIndexStateUpdated(response);
channel.sendResponse(TransportResponse.Empty.INSTANCE);
}

@Override
public String executor() {
return ThreadPool.Names.SAME;
}
}

public static interface Listener {
void onIndexStateUpdated(NodeIndexStateUpdatedResponse response);
void onTimeout();
}

public static class NodeIndexStateUpdatedResponse extends TransportRequest {
private String nodeId;
private long version;

NodeIndexStateUpdatedResponse() {
}

public NodeIndexStateUpdatedResponse(String nodeId, long version) {
this.nodeId = nodeId;
this.version = version;
}

public String nodeId() {
return nodeId;
}

public long version() {
return version;
}

@Override
public void writeTo(StreamOutput out) throws IOException {
super.writeTo(out);
out.writeString(nodeId);
out.writeLong(version);
}

@Override
public void readFrom(StreamInput in) throws IOException {
super.readFrom(in);
nodeId = in.readString();
version = in.readLong();
}
}
}

0 comments on commit 6ab76a5

Please sign in to comment.