Save some work when BlobStoreCacheService is stopping (#81658) (#81717)

There is no reason to build a document if we know the `BlobStoreCacheService` is stopping. We can save a bit a work here.
elastic · Dec 14, 2021 · 7d03826 · 7d03826
1 parent 0d40336
commit 7d03826
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/...in/java/org/elasticsearch/xpack/searchablesnapshots/cache/blob/BlobStoreCacheService.java b/...in/java/org/elasticsearch/xpack/searchablesnapshots/cache/blob/BlobStoreCacheService.java
@@ -242,6 +242,10 @@ public final void putAsync(
         final long timeInEpochMillis,
         final ActionListener<Void> listener
     ) {
+        if (closed.get()) {
+            listener.onFailure(new IllegalStateException("Blob cache service is closed"));
+            return;
+        }
         final String id = generateId(repository, snapshotId, indexId, shardId, name, range);
         try {
             final CachedBlob cachedBlob = new CachedBlob(
@@ -267,10 +271,6 @@ public final void putAsync(
             boolean submitted = false;
             inFlightCacheFills.acquire();
             try {
-                if (closed.get()) {
-                    listener.onFailure(new IllegalStateException("Blob cache service is closed"));
-                    return;
-                }
                 final ActionListener<Void> wrappedListener = ActionListener.runAfter(listener, release);
                 innerPut(request, new ActionListener<IndexResponse>() {
                     @Override