shouldRollGeneration should execute under read lock (#41696)

Translog#shouldRollGeneration should execute under the read lock since it accesses the current writer.
elastic · May 10, 2019 · 809ed3b · 809ed3b
1 parent 2a8a64d
commit 809ed3b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/server/src/main/java/org/elasticsearch/index/translog/Translog.java b/server/src/main/java/org/elasticsearch/index/translog/Translog.java
@@ -561,9 +561,10 @@ public Location add(final Operation operation) throws IOException {
      * @return {@code true} if the current generation should be rolled to a new generation
      */
     public boolean shouldRollGeneration() {
-        final long size = this.current.sizeInBytes();
         final long threshold = this.indexSettings.getGenerationThresholdSize().getBytes();
-        return size > threshold;
+        try (ReleasableLock ignored = readLock.acquire()) {
+            return this.current.sizeInBytes() > threshold;
+        }
     }
 
     /**