Skip to content

Commit

Permalink
Update SamlRealmTests to use TLSv1.2 only (#75324)
Browse files Browse the repository at this point in the history
Recent JDK builds disable TLSv1 and TLSv1.1, which would cause this test
to fail whenever it was (randomly) configured to use those protocols.

For the purposes of this test it is no longer necessary to test with
older protocols, and the test can rely on TLSv1.2 instead.

Resolves: #73314
  • Loading branch information
tvernum committed Jul 14, 2021
1 parent 61f3dae commit 98dca65
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
/**
* Basic unit tests for the SAMLRealm
*/
@SamlTestCase.AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/73314")
public class SamlRealmTests extends SamlTestCase {

public static final String TEST_IDP_ENTITY_ID = "http://demo_josso_1.josso.dev.docker:8081/IDBUS/JOSSO-TUTORIAL/IDP1/SAML2/MD";
Expand Down Expand Up @@ -120,7 +119,7 @@ public void testReadIdpMetadataFromFile() throws Exception {
}

public void testReadIdpMetadataFromHttps() throws Exception {
final String serverProtocol = randomFrom("TLSv1", "TLSv1.1", "TLSv1.2");
final String serverProtocol = "TLSv1.2";
final Path path = getDataPath("idp1.xml");
final String body = new String(Files.readAllBytes(path), StandardCharsets.UTF_8);
final MockSecureSettings mockSecureSettings = new MockSecureSettings();
Expand Down

0 comments on commit 98dca65

Please sign in to comment.