Correct errors - HRLC TermVectorRequest (#35705)

Relates to #35266, #35614
elastic · Nov 19, 2018 · a0e6972 · a0e6972
1 parent 214bc96
commit a0e6972
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 14 deletions.
diff --git a/client/rest-high-level/src/main/java/org/elasticsearch/client/core/TermVectorsRequest.java b/client/rest-high-level/src/main/java/org/elasticsearch/client/core/TermVectorsRequest.java
@@ -170,13 +170,6 @@ public void setPerFieldAnalyzer(Map<String, String> perFieldAnalyzer) {
         this.perFieldAnalyzer = perFieldAnalyzer;
     }
 
-    /**
-     * Sets an artifical document on what to request _termvectors
-     */
-    public void setDoc(XContentBuilder docBuilder) {
-        this.docBuilder = docBuilder;
-    }
-
     /**
      * Sets conditions for terms filtering
      */

diff --git a/client/rest-high-level/src/test/java/org/elasticsearch/client/CrudIT.java b/client/rest-high-level/src/test/java/org/elasticsearch/client/CrudIT.java
@@ -1214,7 +1214,7 @@ public void testMultiTermvectors() throws IOException {
         {
             // test _mtermvectors where MultiTermVectorsRequest is constructed with ids and a template
             String[] expectedIds = {"1", "2"};
-            TermVectorsRequest tvRequestTemplate = new TermVectorsRequest(sourceIndex, "_doc");
+            TermVectorsRequest tvRequestTemplate = new TermVectorsRequest(sourceIndex, "_doc", "fake_id");
             tvRequestTemplate.setFields("field");
             MultiTermVectorsRequest mtvRequest = new MultiTermVectorsRequest(expectedIds, tvRequestTemplate);
 
@@ -1236,10 +1236,10 @@ public void testMultiTermvectors() throws IOException {
             TermVectorsRequest tvRequest1 = new TermVectorsRequest(sourceIndex, "_doc", "1");
             tvRequest1.setFields("field");
             mtvRequest.add(tvRequest1);
-            TermVectorsRequest tvRequest2 = new TermVectorsRequest(sourceIndex, "_doc");
+
             XContentBuilder docBuilder = XContentFactory.jsonBuilder();
             docBuilder.startObject().field("field", "valuex").endObject();
-            tvRequest2.setDoc(docBuilder);
+            TermVectorsRequest tvRequest2 = new TermVectorsRequest(sourceIndex, "_doc", docBuilder);
             mtvRequest.add(tvRequest2);
 
             MultiTermVectorsResponse mtvResponse =

diff --git a/...-high-level/src/test/java/org/elasticsearch/client/documentation/CRUDDocumentationIT.java b/...-high-level/src/test/java/org/elasticsearch/client/documentation/CRUDDocumentationIT.java
@@ -1692,18 +1692,18 @@ public void testMultiTermVectors() throws Exception {
                 new TermVectorsRequest("authors", "_doc", "1");
             tvrequest1.setFields("user");
             request.add(tvrequest1); // <2>
-            TermVectorsRequest tvrequest2 =
-                new TermVectorsRequest("authors", "_doc");
+
             XContentBuilder docBuilder = XContentFactory.jsonBuilder();
             docBuilder.startObject().field("user", "guest-user").endObject();
-            tvrequest2.setDoc(docBuilder);
+            TermVectorsRequest tvrequest2 =
+                new TermVectorsRequest("authors", "_doc", docBuilder);
             request.add(tvrequest2); // <3>
             // end::multi-term-vectors-request
         }
 
         // tag::multi-term-vectors-request-template
         TermVectorsRequest tvrequestTemplate =
-            new TermVectorsRequest("authors", "_doc"); // <1>
+            new TermVectorsRequest("authors", "_doc", "fake_id"); // <1>
         tvrequestTemplate.setFields("user");
         String[] ids = {"1", "2"};
         MultiTermVectorsRequest request =