Skip to content

Commit

Permalink
Skip get_alias tests for 5.x (#31397)
Browse files Browse the repository at this point in the history
Some recent failures on the mixed cluster tests were caused by #31308.
Instead of executing get index API when calling GET /_alias we now go
through the get alias API. The behaviour of such API is slightly
different on 5.6 compared to 6.x and master as to whether indices that
have no aliases are returned or not. In fact #25114 was not backported
to 5.6.

When the 5.6 node is the elected master, if the get alias API goes
through such node or another 5.x node, the get index API will be used
internally and all tests are fine. If some 6.x node is hit though by the
client request, we will go through the get alias API, but we will do it
through the elected master which will not return indices without aliases
(at transport, see MetaData#findAliases on 5.6). That means that in a
mixed cluster this API will return a different result depending on which
node is the elected master and which one is hit by the request.
  • Loading branch information
javanna committed Jun 19, 2018
1 parent 4be2f3e commit a4a1563
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ setup:
---
"Get all aliases via /_alias":
- skip:
version: all
reason: Nik will look on Monday
version: " - 5.99.99"
reason: 5.x doesn't return indices without aliases (at transport)
- do:
indices.create:
index: test_index_3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ setup:
---
"Check empty aliases when getting all aliases via /_alias":
- skip:
version: all
reason: Nik will look on Monday
version: " - 5.99.99"
reason: 5.x doesn't return indices without aliases (at transport)
- do:
indices.get_alias: {}

Expand Down

0 comments on commit a4a1563

Please sign in to comment.