Fix cluster level dense vector stats (#107962)

The cluster level dense vector stats returns the total number of dense vector indices globally including the replicas. This commit fixes the total to only include the value count of the primary indices. This change aligns with the docs stats which also reports the number of primary documents when used in cluster stats. The indices stats API still reports granular results for replicas and primaries so the information is not lost.
elastic · Jun 18, 2024 · a6470fb · a6470fb
1 parent b147d07
commit a6470fb
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/docs/reference/rest-api/common-parms.asciidoc b/docs/reference/rest-api/common-parms.asciidoc
@@ -507,6 +507,10 @@ Return all statistics.
 `completion`::
 <<completion-suggester,Completion suggester>> statistics.
 
+`dense_vector`::
+Total number of dense vectors indexed.
+<<indices-refresh,Index refreshes>> can affect this statistic.
+
 `docs`::
 Number of documents, number of deleted docs which have not yet merged out, and total size in bytes.
 <<indices-refresh,Index refreshes>> can affect this statistic.

diff --git a/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/cluster.stats/10_basic.yml b/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/cluster.stats/10_basic.yml
@@ -258,14 +258,12 @@
 ---
 "Dense vector stats":
   - requires:
-      cluster_features: [ "gte_v8.10.0" ]
-      reason: "dense vector stats added in 8.10"
+      cluster_features: [ "gte_v8.15.0" ]
+      reason: "dense vector stats reports from primary indices in 8.15"
   - do:
       indices.create:
         index: test1
         body:
-          settings:
-            number_of_replicas: 0
           mappings:
             properties:
               vector:
@@ -283,8 +281,6 @@
       indices.create:
         index: test2
         body:
-          settings:
-            number_of_replicas: 0
           mappings:
             properties:
               vector:

diff --git a/server/src/main/java/org/elasticsearch/action/admin/cluster/stats/ClusterStatsIndices.java b/server/src/main/java/org/elasticsearch/action/admin/cluster/stats/ClusterStatsIndices.java
@@ -74,14 +74,14 @@ public ClusterStatsIndices(
                 if (shardStats.getShardRouting().primary()) {
                     indexShardStats.primaries++;
                     docs.add(shardCommonStats.getDocs());
+                    denseVectorStats.add(shardCommonStats.getDenseVectorStats());
                     sparseVectorStats.add(shardCommonStats.getSparseVectorStats());
                 }
                 store.add(shardCommonStats.getStore());
                 fieldData.add(shardCommonStats.getFieldData());
                 queryCache.add(shardCommonStats.getQueryCache());
                 completion.add(shardCommonStats.getCompletion());
                 segments.add(shardCommonStats.getSegments());
-                denseVectorStats.add(shardCommonStats.getDenseVectorStats());
             }
 
             searchUsageStats.add(r.searchUsageStats());

diff --git a/server/src/main/java/org/elasticsearch/rest/action/cat/RestShardsAction.java b/server/src/main/java/org/elasticsearch/rest/action/cat/RestShardsAction.java
@@ -254,7 +254,7 @@ protected Table getTableWithHeader(final RestRequest request) {
         );
         table.addCell(
             "dense_vector.value_count",
-            "alias:dvc,denseVectorCount;default:false;text-align:right;desc:total count of indexed dense vector"
+            "alias:dvc,denseVectorCount;default:false;text-align:right;desc:number of indexed dense vectors in shard"
         );
         table.addCell(
             "sparse_vector.value_count",