Add params to the LTR rescorer (#102566)

elastic · Nov 30, 2023 · b5e9a73 · b5e9a73
1 parent 64444d2
commit b5e9a73
Show file tree

Hide file tree

Showing 14 changed files with 830 additions and 1,018 deletions.
diff --git a/...c/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/LearnToRankConfig.java b/...c/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/LearnToRankConfig.java
@@ -61,6 +61,10 @@ public static LearnToRankConfig fromXContentLenient(XContentParser parser) {
         return LENIENT_PARSER.apply(parser, null).build();
     }
 
+    public static Builder builder(LearnToRankConfig config) {
+        return new Builder(config);
+    }
+
     private final List<LearnToRankFeatureExtractorBuilder> featureExtractorBuilders;
 
     public LearnToRankConfig(Integer numTopFeatureImportanceValues, List<LearnToRankFeatureExtractorBuilder> featureExtractorBuilders) {

diff --git a/.../java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/LearnToRankConfigUpdate.java b/.../java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/LearnToRankConfigUpdate.java
diff --git a/...in/core/src/main/java/org/elasticsearch/xpack/core/ml/ltr/MlLTRNamedXContentProvider.java b/...in/core/src/main/java/org/elasticsearch/xpack/core/ml/ltr/MlLTRNamedXContentProvider.java
@@ -10,9 +10,7 @@
 import org.elasticsearch.plugins.spi.NamedXContentProvider;
 import org.elasticsearch.xcontent.NamedXContentRegistry;
 import org.elasticsearch.xpack.core.ml.inference.trainedmodel.InferenceConfig;
-import org.elasticsearch.xpack.core.ml.inference.trainedmodel.InferenceConfigUpdate;
 import org.elasticsearch.xpack.core.ml.inference.trainedmodel.LearnToRankConfig;
-import org.elasticsearch.xpack.core.ml.inference.trainedmodel.LearnToRankConfigUpdate;
 import org.elasticsearch.xpack.core.ml.inference.trainedmodel.LenientlyParsedInferenceConfig;
 import org.elasticsearch.xpack.core.ml.inference.trainedmodel.StrictlyParsedInferenceConfig;
 import org.elasticsearch.xpack.core.ml.inference.trainedmodel.ltr.LearnToRankFeatureExtractorBuilder;
@@ -46,14 +44,6 @@ public List<NamedXContentRegistry.Entry> getNamedXContentParsers() {
                 LearnToRankConfig::fromXContentStrict
             )
         );
-        // Inference Config Update
-        namedXContent.add(
-            new NamedXContentRegistry.Entry(
-                InferenceConfigUpdate.class,
-                LearnToRankConfigUpdate.NAME,
-                LearnToRankConfigUpdate::fromXContentStrict
-            )
-        );
         // LTR extractors
         namedXContent.add(
             new NamedXContentRegistry.Entry(
@@ -71,14 +61,6 @@ public List<NamedWriteableRegistry.Entry> getNamedWriteables() {
         namedWriteables.add(
             new NamedWriteableRegistry.Entry(InferenceConfig.class, LearnToRankConfig.NAME.getPreferredName(), LearnToRankConfig::new)
         );
-        // Inference config update
-        namedWriteables.add(
-            new NamedWriteableRegistry.Entry(
-                InferenceConfigUpdate.class,
-                LearnToRankConfigUpdate.NAME.getPreferredName(),
-                LearnToRankConfigUpdate::new
-            )
-        );
         // LTR Extractors
         namedWriteables.add(
             new NamedWriteableRegistry.Entry(