SLM uneahlthy policies diagnosis recommends correct URL in action (#9…

…1506) (#91584)

THe SLM indicator advises to check the uneahlthy SLM policy to get more
details about the health condition.
The current message is something along the lines of
```
Check the snapshot lifecycle policy for detailed failure info:
- /_slm/policy/<cloud-snapshot-{now/d}>?human
```
This message uses the policy name (ie. `<cloud-snapshot-{now/d}>`) as
opposed to the policy id (ie. `/_slm/policy/cloud-snapshot-policy?human`).

This changes the diagnosis to advise the correct URL using the policy
id.

docs/changelog/91506.yaml

@@ -0,0 +1,5 @@
+pr: 91506
+summary: SLM uneahlthy policies diagnosis recommends correct URL in action
+area: Health
+type: bug
+issues: []

x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/slm/SlmHealthIndicatorService.java

@@ -159,7 +159,7 @@ public HealthIndicatorResult calculate(boolean explain, HealthInfo healthInfo) {
                     : "An automated snapshot policy is unhealthy:\n") + unhealthyPolicyCauses;
 
                 String unhealthyPolicyActions = unhealthyPolicies.stream()
-                    .map(policy -> "- /_slm/policy/" + policy.getName() + "?human")
+                    .map(policy -> "- /_slm/policy/" + policy.getPolicy().getId() + "?human")
                     .collect(Collectors.joining("\n"));
                 String action = "Check the snapshot lifecycle "
                     + (unhealthyPolicies.size() > 1 ? "policies" : "policy")

x-pack/plugin/ilm/src/test/java/org/elasticsearch/xpack/slm/SlmHealthIndicatorServiceTests.java

@@ -222,7 +222,7 @@ public void testIsYellowWhenPoliciesHaveFailedForMoreThanWarningThreshold() {
                                     + "] repeated failures without successful execution since ["
                                     + FORMATTER.formatMillis(execTime)
                                     + "]",
-                                "Check the snapshot lifecycle policy for detailed failure info:\n- /_slm/policy/test-policy?human"
+                                "Check the snapshot lifecycle policy for detailed failure info:\n- /_slm/policy/policy-id?human"
                             ),
                             List.of("test-policy")
                         )
@@ -302,7 +302,7 @@ private static Map<String, SnapshotLifecyclePolicyMetadata> createSlmPolicyWithI
         return Map.of(
             "test-policy",
             SnapshotLifecyclePolicyMetadata.builder()
-                .setPolicy(new SnapshotLifecyclePolicy("id", "test-policy", "", "test-repository", null, null))
+                .setPolicy(new SnapshotLifecyclePolicy("policy-id", "test-policy", "", "test-repository", null, null))
                 .setVersion(1L)
                 .setModifiedDate(System.currentTimeMillis())
                 .setLastSuccess(lastSuccess)