Remove bogus assertion in CacheFile (#71174)

There's a bogus assertion in CacheFile that expects a channel to be available whenever we continue writing to it. In case where the range listener does not care about the write anymore (i.e. all reads are ok), it does not continues to hold onto the file, however, which is ok. Closes #71083
elastic · Apr 2, 2021 · d2aa194 · d2aa194
1 parent 6d0d447
commit d2aa194
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/...ots/src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/common/CacheFile.java b/...ots/src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/common/CacheFile.java
@@ -365,7 +365,6 @@ public Future<Integer> populateAndRead(
                     @Override
                     protected void doRun() throws Exception {
                         if (reference.tryIncRef() == false) {
-                            assert false : "expected a non-closed channel reference";
                             throw new AlreadyClosedException("Cache file channel has been released and closed");
                         }
                         try {

diff --git a/...ain/java/org/elasticsearch/xpack/searchablesnapshots/cache/shared/FrozenCacheService.java b/...ain/java/org/elasticsearch/xpack/searchablesnapshots/cache/shared/FrozenCacheService.java
@@ -675,7 +675,6 @@ public StepListener<Integer> populateAndRead(
                         @Override
                         protected void doRun() throws Exception {
                             if (CacheFileRegion.this.tryIncRef() == false) {
-                                // assert false : "expected a non-closed channel reference";
                                 throw new AlreadyClosedException("Cache file channel has been released and closed");
                             }
                             try {