-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tidy up ClusterApplierService (#76837)
This commit cleans up some cruft left over from older versions of the `ClusterApplierService`: - `UpdateTask` doesn't need to implement lots of interfaces and give access to its internals, it can just pass appropriate arguments to `runTasks()`. - No need for the `runOnApplierThread` override with a default priority, just have callers be explicit about the priority. - `submitStateUpdateTask` takes a config which never has a timeout, may as well just pass the priority and remove the dead code - `SafeClusterApplyListener` doesn't need to be a `ClusterApplyListener`, may as well just be an `ActionListener<Void>`. - No implementations of `ClusterApplyListener` care about the source argument, may as well drop it. - Adds assertions to prevent `ClusterApplyListener` implementations from throwing exceptions since we just swallow them. - No need to override getting the current time in the `ClusterApplierService`, we can control this from the `ThreadPool`.
- Loading branch information
1 parent
627c0ee
commit ead0020
Showing
16 changed files
with
324 additions
and
267 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.