Skip to content

Commit

Permalink
INGEST: Remove Outdated TODOs (#33458)
Browse files Browse the repository at this point in the history
* CompoundProcessor is in the ingest package now
-> resolved
* Java generics don't offer type checking so nothing
can be done here -> remvoed TODO and test
* #16019 was closed and not acted on
-> todo can go away
  • Loading branch information
original-brownbear committed Sep 8, 2018
1 parent ab9e2cd commit f27c3dc
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
//TODO(simonw): can all these classes go into org.elasticsearch.ingest?

package org.elasticsearch.ingest;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,6 @@ public void testReadBooleanPropertyInvalidType() {
}
}

// TODO(talevy): Issue with generics. This test should fail, "int" is of type List<Integer>
public void testOptional_InvalidType() {
List<String> val = ConfigurationUtils.readList(null, null, config, "int");
assertThat(val, equalTo(Collections.singletonList(2)));
}

public void testReadStringOrIntProperty() {
String val1 = ConfigurationUtils.readStringOrIntProperty(null, null, config, "foo", null);
String val2 = ConfigurationUtils.readStringOrIntProperty(null, null, config, "num", null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ public class IngestClientIT extends ESIntegTestCase {

@Override
protected Settings nodeSettings(int nodeOrdinal) {
// TODO: Remove this method once gets in: https://github.com/elastic/elasticsearch/issues/16019
if (nodeOrdinal % 2 == 0) {
return Settings.builder().put("node.ingest", false).put(super.nodeSettings(nodeOrdinal)).build();
}
Expand Down

0 comments on commit f27c3dc

Please sign in to comment.