-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
There were a number of issues around data streams rolling over during a snapshot that are fixed in this PR: 1. If partial snapshots cause a data stream to not be fully snapshotted because an index gets concurrently deleted we must not add it to the resulting cluster state (otherwise we trip assertions on either snapshot itself or a later restore, depending on whether or not the complete global state is snapshotted). 2. When a non-partial snapshot is running we must not allow a datastream rollover, otherwise we cannot finish the datastream snapshot correctly because the newly created write index has not become part of the snapshot. 3. If any part of a datastream fails snapshotting or gets concurrently deleted during a partial snapshot we must not add it to `SnapshotInfo` same as we do not add concurrently deleted indices to it.
- Loading branch information
1 parent
a440fdf
commit f933f9c
Showing
3 changed files
with
108 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters