Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failures in rename #100356

Closed
nik9000 opened this issue Oct 5, 2023 · 2 comments · Fixed by #100370
Closed

Test failures in rename #100356

nik9000 opened this issue Oct 5, 2023 · 2 comments · Fixed by #100370
Assignees
@costin
Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team >test-failure Triaged test failures from CI v8.12.0

Comments

@nik9000
Copy link
Member

nik9000 commented Oct 5, 2023

CI Link

https://gradle-enterprise.elastic.co/s/xws6gmgwdwnmm/tests/overview?outcome=failed

Repro line

./gradlew ':x-pack:plugin:esql:test' --tests "org.elasticsearch.xpack.esql.CsvTests" -Dtests.method="test {rename.RenameProjectEval}" -Dtests.seed=F32BCA1B870438F -Dtests.locale=ar-LY -Dtests.timezone=UTC -Druntime.java=21

Does it reproduce?

Yes

Applicable branches

main

Failure history

No response

Failure excerpt

java.lang.AssertionError: java.lang.IllegalStateException: can't release already released block [IntVectorBlock[vector=IntArrayVector[positions=3, values=[2, 5, 4]]]]
@nik9000 nik9000 added >test-failure Triaged test failures from CI :Analytics/ES|QL AKA ESQL v8.12.0 labels Oct 5, 2023
@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Oct 5, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

This was referenced Oct 5, 2023
Merged
Merged
@nik9000 nik9000 changed the title rename test failures Test failures in rename Oct 5, 2023
elasticsearchmachine pushed a commit that referenced this issue Oct 5, 2023
@nik9000
ESQL: Silence failing test (#100357)
7ff9c9f 
It's not releasing blocks.

Relates to #100356
@costin costin mentioned this issue Oct 5, 2023
Closed
23 tasks
costin added a commit to costin/elasticsearch that referenced this issue Oct 5, 2023
@costin
ESQL: Page shouldn't close a block twice
a7cb6ab 
Page now takes into account that a block can be used in multiple
 positions (such as the same column aliased under multiple names).

Relates elastic#100001
Fix elastic#100365
Fix elastic#100356
@costin costin mentioned this issue Oct 5, 2023
Merged
costin added a commit that referenced this issue Oct 6, 2023
@costin
ESQL: Page shouldn't close a block twice (#100370)
44068cb 
Page now takes into account that a block can be used in multiple
 positions (such as the same column aliased under multiple names).
Introduce newPageAndRelease method that handles clean-up of blocks that
 are not-used when creating a new page

Relates #100001
Fix #100365
Fix #100356
costin added a commit to costin/elasticsearch that referenced this issue Oct 6, 2023
@costin
ESQL: Page shouldn't close a block twice (elastic#100370)
7d71cec 
Page now takes into account that a block can be used in multiple
 positions (such as the same column aliased under multiple names).
Introduce newPageAndRelease method that handles clean-up of blocks that
 are not-used when creating a new page

Relates elastic#100001
Fix elastic#100365
Fix elastic#100356

(cherry picked from commit 44068cb)
elasticsearchmachine pushed a commit that referenced this issue Oct 6, 2023
@costin
[8.11] ESQL: Page shouldn't close a block twice (#100370) (#100457)
da61634 
* ESQL: Page shouldn't close a block twice (#100370)

Page now takes into account that a block can be used in multiple
 positions (such as the same column aliased under multiple names).
Introduce newPageAndRelease method that handles clean-up of blocks that
 are not-used when creating a new page

Relates #100001
Fix #100365
Fix #100356

(cherry picked from commit 44068cb)

* Fix order inside test
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this issue Oct 9, 2023
@nik9000 @davidkyle
ESQL: Silence failing test (elastic#100357)
de84414 
It's not releasing blocks.

Relates to elastic#100356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@costin costin

Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team >test-failure Triaged test failures from CI v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: Page shouldn't close a block twice costin/elasticsearch
3 participants
@costin @nik9000 @elasticsearchmachine