Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update internal unconditional rollover calls to use lazy rollover #104083

Closed
dakrone opened this issue Jan 8, 2024 · 1 comment · Fixed by #104597 or #105273
Closed

Update internal unconditional rollover calls to use lazy rollover #104083

dakrone opened this issue Jan 8, 2024 · 1 comment · Fixed by #104597 or #105273
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team

Comments

@dakrone
Copy link
Member

dakrone commented Jan 8, 2024

Description

Currently we have some of our IndexTemplateRegistry subclasses that invoke unconditional rollovers after templates have been upgraded. One thing that would be good to do is to make use of the recently merged lazy rollover flag for these calls.

We can look at uses of the applyRolloverAfterTemplateV2Upgrade() flag to see where these are used.
@dakrone dakrone added >enhancement :Data Management/Indices APIs APIs to create and manage indices and templates labels Jan 8, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@gmarouli gmarouli mentioned this issue Jan 23, 2024
Merged
elasticsearchmachine pushed a commit that referenced this issue Jan 23, 2024
@axw
x-pack/plugin/core: make automatic rollovers lazy (#104597)
9e074b8 
Apply automatic rollovers lazily, upon the next write, to avoid
unnecessary empty backing indices.

See #89346

Fixes #104083
@axw axw reopened this Jan 25, 2024
This was referenced Feb 2, 2024
Merged
Merged
elasticsearchmachine pushed a commit that referenced this issue Feb 9, 2024
@axw
Revert "Revert "x-pack/plugin/core: make automatic rollovers lazy"" (#…
071dd31 
…105273)

Reverts #104734.
#104732 has been fixed,
so it's safe to use lazy rollovers now.

Fixes #104083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
3 participants
@dakrone @axw @elasticsearchmachine