DefaultCheckpointProviderTests#testHandlingShardFailures doesn't work
#104533
Assignees
Labels
:ml/Transform
Transform
Team:ML
Meta label for the ML team
>test
Issues or PRs that are addressing/adding tests
Comments
DaveCTurner
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this issue
Mar 26, 2024
When there are no remote or local clusters for a given source index, we call the listener's `onFailure` method with a `CheckpointException`. A running transform will fail and retry, eventually moving into an unhealthy and failed state. Any call to the stats API will note the checkpoint failure and return. This fixes a timeout issue calling the Transform stats API and prevents the Transform from being stuck in indexing. Fix elastic#106790 Fix elastic#104533
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this issue
Mar 27, 2024
When there are no remote or local clusters for a given source index, we call the listener's `onFailure` method with a `CheckpointException`. A running transform will fail and retry, eventually moving into an unhealthy and failed state. Any call to the stats API will note the checkpoint failure and return. This fixes a timeout issue calling the Transform stats API and prevents the Transform from being stuck in indexing. Fix elastic#106790 Fix elastic#104533
elasticsearchmachine
pushed a commit
that referenced
this issue
Mar 27, 2024
When there are no remote or local clusters for a given source index, we call the listener's `onFailure` method with a `CheckpointException`. A running transform will fail and retry, eventually moving into an unhealthy and failed state. Any call to the stats API will note the checkpoint failure and return. This fixes a timeout issue calling the Transform stats API and prevents the Transform from being stuck in indexing. Fix #106790 Fix #104533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DefaultCheckpointProviderTests#testHandlingShardFailuresends with alatch.await(10, TimeUnit.SECONDS);but that doesn't check that the latch has been counted down. In fact it isn't counted down, this test always waits for 10s before timing out and passing. I'm pretty sure it needs attention, either fixing with asafeAwait(latch), or perhaps just removing if it's no longer relevant.The text was updated successfully, but these errors were encountered: