Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] NodeConnectionsServiceTests testOnlyBlocksOnConnectionsToNewNodes failing #105556

Open
thecoop opened this issue Feb 15, 2024 · 4 comments
Open

[CI] NodeConnectionsServiceTests testOnlyBlocksOnConnectionsToNewNodes failing #105556

thecoop opened this issue Feb 15, 2024 · 4 comments
Assignees
@nicktindall
Labels
:Distributed/Network Http and internode communication implementations low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Meta label for distributed team >test-failure Triaged test failures from CI

Comments

@thecoop
Copy link
Member

thecoop commented Feb 15, 2024

Build scan:
https://gradle-enterprise.elastic.co/s/m4vy4ftjv7cya/tests/:server:test/org.elasticsearch.cluster.NodeConnectionsServiceTests/testOnlyBlocksOnConnectionsToNewNodes

Reproduction line:

./gradlew ':server:test' --tests "org.elasticsearch.cluster.NodeConnectionsServiceTests.testOnlyBlocksOnConnectionsToNewNodes" -Dtests.seed=2FFE3EE707EDD8D1 -Dtests.locale=nb -Dtests.timezone=Pacific/Tahiti -Druntime.java=21

Applicable branches:
main

Reproduces locally?:
No

Failure history:
Failure dashboard for org.elasticsearch.cluster.NodeConnectionsServiceTests#testOnlyBlocksOnConnectionsToNewNodes

Failure excerpt:

java.lang.Exception: Test abandoned because suite timeout was reached.

  at __randomizedtesting.SeedInfo.seed([2FFE3EE707EDD8D1]:0)
@thecoop thecoop added :Distributed/Network Http and internode communication implementations >test-failure Triaged test failures from CI labels Feb 15, 2024
@elasticsearchmachine elasticsearchmachine added blocker Team:Distributed Meta label for distributed team labels Feb 15, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@arteam arteam self-assigned this Feb 15, 2024
@arteam arteam added low-risk An open issue or test failure that is a low risk to future releases and removed blocker labels Feb 15, 2024
arteam added a commit to arteam/elasticsearch that referenced this issue Feb 19, 2024
@arteam
Don't fail on BrokenBarrierException
f49e252 
If the barrier has been reset that means the test has already completed and we
don't care about node connection attempts and shouldn't throw an assertion error and fail
the test

Resolve elastic#105556
@arteam arteam mentioned this issue Feb 19, 2024
Closed
@DaveCTurner
Copy link
Contributor

Reproduces locally?:
No

FWIW this reproduced for me locally after ~350k iterations (~12h). I think that's a record.

@arteam
Copy link
Contributor

arteam commented Mar 25, 2024

I've ran this test around 25K without failures until I my machine ran out of TCP ports. This test doesn't reproduce for me and failed only once over 11K runs on CI. I'm going to close the issue, feel free to re-open if this issue reproduces again on CI.

@arteam arteam closed this as completed Mar 25, 2024
@nielsbauman
Copy link
Contributor

@arteam found another one: https://gradle-enterprise.elastic.co/s/6jgmbgitrxihq/tests/:server:test/org.elasticsearch.cluster.NodeConnectionsServiceTests/testOnlyBlocksOnConnectionsToNewNodes

@nielsbauman nielsbauman reopened this May 24, 2024
@arteam arteam removed their assignment Jun 30, 2024
@nicktindall nicktindall self-assigned this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicktindall nicktindall

Labels
:Distributed/Network Http and internode communication implementations low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Meta label for distributed team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[test] Don't fail on BrokenBarrierException arteam/elasticsearch
6 participants
@nicktindall @arteam @thecoop @DaveCTurner @nielsbauman @elasticsearchmachine