Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow fuzziness specified as a minimum similarity and require edits [0,2] #10638

Closed
s1monw opened this issue Apr 16, 2015 · 4 comments
Closed

Don't allow fuzziness specified as a minimum similarity and require edits [0,2] #10638

s1monw opened this issue Apr 16, 2015 · 4 comments
Assignees
@s1monw
Labels
>breaking help wanted adoptme :Search/Search Search-related issues that do not fall into other categories v2.0.0-beta1

Comments

@s1monw
Copy link
Contributor

s1monw commented Apr 16, 2015

Lucene deprecated this in 4.0 and we only try best effort to support it. Folks should only use edit distance rather than some length based similarity. Yet the formular is simple enough such that users can still do it in the client if they really need to.
s1monw added a commit that referenced this issue Apr 16, 2015
@s1monw
[TEST] mute test and remove once #10638 is in
5f9bac4
@rmuir
Copy link
Contributor

rmuir commented Apr 16, 2015

+1

@s1monw
Copy link
Contributor Author

s1monw commented Apr 17, 2015

@clintongormley are you ok with this

@s1monw
Copy link
Contributor Author

s1monw commented Apr 21, 2015

ping @clintongormley

@clintongormley
Copy link

+1 remove min_similarity and percentages of fuzziness. Fuzziness should accept 1, 2, or AUTO

@s1monw s1monw mentioned this issue Jul 14, 2015
Merged
@s1monw s1monw self-assigned this Jul 14, 2015
s1monw added a commit to s1monw/elasticsearch that referenced this issue Jul 14, 2015
@s1monw
Don't allow fuzziness specified as a and require edits [0,2]
09bd19b 
Lucene deprecated this in 4.0 and we only try best effort to support it.
Folks should only use edit distance rather than some length based
similarity. Yet the formular is simple enough such that users can
still do it in the client if they really need to.

Closes elastic#10638
@julen julen mentioned this issue Feb 1, 2016
Closed
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Query DSL labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
>breaking help wanted adoptme :Search/Search Search-related issues that do not fall into other categories v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @rmuir @s1monw