[CI] FileSettingsServiceTests testStopWorksIfProcessingDidntReturnYet failing #106968
Assignees
Labels
:Core/Infra/Settings
Settings infrastructure and APIs
low-risk
An open issue or test failure that is a low risk to future releases
Team:Core/Infra
Meta label for core/infra team
>test-failure
Triaged test failures from CI
Comments
mark-vieira
added
:Core/Infra/Settings
elasticsearchmachine
added
blocker
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Getting loads of these failures in other test methods so I've muted the entire class. |
elasticsearchmachine
added
the
needs:risk
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this issue
Apr 30, 2024
When the file watched by file settings is initially missing, a special method in reserved state service is called to write a dummy cluster state entry. In the case of tests, there is no real running master service, so when the task is submitted, the file watcher thread actually barfs and the watcher dies, silently. That then causes the test to timeout as it waits indefinitely but the file watcher is no longer watching for the test file that was written. This commit mocks out writing this empty state in the reserved state service. It also collapses the two tests that check stopping while blocked in processing works since they were almost exactly the same. closes elastic#106968
rjernst
added
low-risk
rjernst
added a commit
that referenced
this issue
May 8, 2024
When the file watched by file settings is initially missing, a special method in reserved state service is called to write a dummy cluster state entry. In the case of tests, there is no real running master service, so when the task is submitted, the file watcher thread actually barfs and the watcher dies, silently. That then causes the test to timeout as it waits indefinitely but the file watcher is no longer watching for the test file that was written. This commit mocks out writing this empty state in the reserved state service. It also collapses the two tests that check stopping while blocked in processing works since they were almost exactly the same. closes #106968
markjhoy
pushed a commit
to markjhoy/elasticsearch
that referenced
this issue
May 9, 2024
When the file watched by file settings is initially missing, a special method in reserved state service is called to write a dummy cluster state entry. In the case of tests, there is no real running master service, so when the task is submitted, the file watcher thread actually barfs and the watcher dies, silently. That then causes the test to timeout as it waits indefinitely but the file watcher is no longer watching for the test file that was written. This commit mocks out writing this empty state in the reserved state service. It also collapses the two tests that check stopping while blocked in processing works since they were almost exactly the same. closes elastic#106968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Only seen one instance of this but I was able to reproduce locally.
Build scan:
https://gradle-enterprise.elastic.co/s/vpruqgunowhmy/tests/:server:test/org.elasticsearch.reservedstate.service.FileSettingsServiceTests/testStopWorksIfProcessingDidntReturnYet
Reproduction line:
Applicable branches:
main
Reproduces locally?:
Yes
Failure history:
Failure dashboard for
org.elasticsearch.reservedstate.service.FileSettingsServiceTests#testStopWorksIfProcessingDidntReturnYetFailure excerpt:
The text was updated successfully, but these errors were encountered: