Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] IndexShardTests testFlushTimeExcludingWaiting failing #107462

Closed
jonathan-buttner opened this issue Apr 15, 2024 · 1 comment · Fixed by #108109
Closed

[CI] IndexShardTests testFlushTimeExcludingWaiting failing #107462

jonathan-buttner opened this issue Apr 15, 2024 · 1 comment · Fixed by #108109
Assignees
@arteam
Labels
:Distributed/Engine Anything around managing Lucene and the Translog in an open shard. low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Meta label for distributed team >test-failure Triaged test failures from CI

Comments

@jonathan-buttner
Copy link
Contributor

Build scan:
https://gradle-enterprise.elastic.co/s/hk2usjoyg3faw/tests/:server:test/org.elasticsearch.index.shard.IndexShardTests/testFlushTimeExcludingWaiting

Reproduction line:

./gradlew ':server:test' --tests "org.elasticsearch.index.shard.IndexShardTests.testFlushTimeExcludingWaiting" -Dtests.seed=4D6C8EAB053718AC -Dtests.locale=en-IE -Dtests.timezone=Etc/Greenwich -Druntime.java=21

Applicable branches:
main

Reproduces locally?:
Didn't try

Failure history:
Failure dashboard for org.elasticsearch.index.shard.IndexShardTests#testFlushTimeExcludingWaiting

Failure excerpt:

java.lang.AssertionError: Flush time excluding waiting should less than flush time with waiting
Expected: a value less than <14L>
     but: <14L> was equal to <14L>

  at __randomizedtesting.SeedInfo.seed([4D6C8EAB053718AC:5A278E802E505E28]:0)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
  at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2155)
  at org.elasticsearch.index.shard.IndexShardTests.testFlushTimeExcludingWaiting(IndexShardTests.java:4027)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1583)
@jonathan-buttner jonathan-buttner added :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. >test-failure Triaged test failures from CI labels Apr 15, 2024
@elasticsearchmachine elasticsearchmachine added blocker Team:Distributed Meta label for distributed team labels Apr 15, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@jonathan-buttner jonathan-buttner mentioned this issue Apr 15, 2024
Merged
elasticsearchmachine pushed a commit that referenced this issue Apr 15, 2024
@jonathan-buttner
Skipping failing test (#107464)
a2d6ffe 
Muting #107462
@idegtiarenko idegtiarenko mentioned this issue Apr 16, 2024
Closed
@fcofdez fcofdez added low-risk An open issue or test failure that is a low risk to future releases and removed blocker labels Apr 18, 2024
@arteam arteam self-assigned this Apr 26, 2024
arteam added a commit that referenced this issue Apr 30, 2024
@arteam
Fix IndexShardTests#testFlushTimeExcludingWaiting
60c3c50 
It may take less than a millisecond to acquire/release a lock with no contention,
and flush stats have only millisecond resolution, so we can't guarantee that flush
time excluding waiting is actually less than flushTime after rounding.

So, we have to relax the assertion and make it `lessThanOrEqualTo` instead of
`lessThan`

Fixes #107462
@arteam arteam mentioned this issue Apr 30, 2024
Merged
arteam added a commit that referenced this issue May 2, 2024
@arteam
Fix IndexShardTests#testFlushTimeExcludingWaiting (#108109)
b80b683 
It may take less than a millisecond to acquire/release a lock with no contention,
and flush stats have only millisecond resolution, so we can't guarantee that flush
time excluding waiting is actually less than flushTime after rounding.

So, we have to relax the assertion and make it `lessThanOrEqualTo` instead of
`lessThan`

Fixes #107462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arteam arteam

Labels
:Distributed/Engine Anything around managing Lucene and the Translog in an open shard. low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Meta label for distributed team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix IndexShardTests#testFlushTimeExcludingWaiting elastic/elasticsearch
4 participants
@fcofdez @arteam @jonathan-buttner @elasticsearchmachine