Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSDB rollover logs should default to Debug #107473

Closed
StephanErb opened this issue Apr 15, 2024 · 2 comments · Fixed by #109094
Closed

TSDB rollover logs should default to Debug #107473

StephanErb opened this issue Apr 15, 2024 · 2 comments · Fixed by #109094
Assignees
@martijnvg
Labels
>enhancement :StorageEngine/Metrics You know, for Metrics Team:StorageEngine

Comments

@StephanErb
Copy link

Description

We have adopted TSDB widely. One of the most common log messages are these TSDB logs:

[elasticsearch.server][INFO] [.ds-metrics-prometheus.collector-default-2024.04.03-000867] updating [index.time_series.end_time] from [2024-04-04T08:03:44.000Z] to [2024-04-04T08:08:43.000Z]

They don't really add much value from an end-user perspective. I thus believe those should be logged at debug level only.
@StephanErb StephanErb added >enhancement needs:triage Requires assignment of a team area label labels Apr 15, 2024
@StephanErb StephanErb changed the title TSDB Rollover Logs should default to Debug TSDB rollover logs should default to Debug Apr 15, 2024
@williamrandolph williamrandolph added the :StorageEngine/Metrics You know, for Metrics label Apr 15, 2024
@elasticsearchmachine elasticsearchmachine added Team:StorageEngine and removed needs:triage Requires assignment of a team area label labels Apr 15, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@martijnvg
Copy link
Member

martijnvg commented Apr 16, 2024 via email

@martijnvg martijnvg self-assigned this May 28, 2024
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue May 28, 2024
@martijnvg
Introduce Silent setting property.
df5ccde 
The `Setting.Propery#Silent` controls whether setting updates are logged at info or debug level. If this property is set then setting updates are logged at debug level, other at info level (default).

This is for index settings that are updated at regular interval by an automatic process. This is to reduce log messages.

Closes elastic#107473
@martijnvg martijnvg mentioned this issue May 28, 2024
Merged
martijnvg added a commit that referenced this issue May 30, 2024
@martijnvg
Log index scoped setting update at debug level (#109094)
a52134c 
Setting updates are logged at info level. Typically these log messages are only useful for debugging purposes. Some index scoped settings are updated more frequently then other type of settings. Typically the index settings that are updated via an automatic process (such as the index.time_series.end_time index setting). These setting updates can add to a significant volume of info log messages.

This PR changes the log level of setting update log messages for index settings only from INFO to DEBUG. This to lower the default volume of info log messages.

Closes #107473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martijnvg martijnvg

Labels
>enhancement :StorageEngine/Metrics You know, for Metrics Team:StorageEngine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log index scoped setting update at debug level martijnvg/elasticsearch
4 participants
@StephanErb @martijnvg @williamrandolph @elasticsearchmachine