Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] TimeSeriesAggregationOperatorTests testBasicRateOrdinalBased failing #107710

Closed
maxhniebergall opened this issue Apr 22, 2024 · 2 comments · Fixed by #108148
Closed

[CI] TimeSeriesAggregationOperatorTests testBasicRateOrdinalBased failing #107710

maxhniebergall opened this issue Apr 22, 2024 · 2 comments · Fixed by #108148
Assignees
@dnhatn
Labels
low-risk An open issue or test failure that is a low risk to future releases :StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test-failure Triaged test failures from CI

Comments

@maxhniebergall
Copy link
Member

Build scan:
https://gradle-enterprise.elastic.co/s/ugg43k5rlniw6/tests/:x-pack:plugin:esql:compute:test/org.elasticsearch.compute.operator.TimeSeriesAggregationOperatorTests/testBasicRateOrdinalBased

Reproduction line:

./gradlew ':x-pack:plugin:esql:compute:test' --tests "org.elasticsearch.compute.operator.TimeSeriesAggregationOperatorTests.testBasicRateOrdinalBased" -Dtests.seed=CD2A56F5755BF7F2 -Dtests.locale=mt-MT -Dtests.timezone=Asia/Kamchatka -Druntime.java=21

Applicable branches:
main

Reproduces locally?:
Yes

Failure history:
Failure dashboard for org.elasticsearch.compute.operator.TimeSeriesAggregationOperatorTests#testBasicRateOrdinalBased

Failure excerpt:

java.lang.AssertionError: 
Expected: <{p1=0.3153153153153153, p2=3.230769230769231, p3=0.5}>
     but: was <{p1=0.3963963963963964, p2=2.769230769230769, p3=0.5}>

  at __randomizedtesting.SeedInfo.seed([CD2A56F5755BF7F2:C694ED27BD7EC4CD]:0)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
  at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2151)
  at org.elasticsearch.compute.operator.TimeSeriesAggregationOperatorTests.testBasicRateOrdinalBased(TimeSeriesAggregationOperatorTests.java:262)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1583)
@maxhniebergall maxhniebergall added :Analytics/ES|QL AKA ESQL >test-failure Triaged test failures from CI labels Apr 22, 2024
@elasticsearchmachine elasticsearchmachine added blocker Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Apr 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@dnhatn dnhatn self-assigned this Apr 22, 2024
@dnhatn dnhatn added :StorageEngine/TSDB You know, for Metrics and removed blocker :Analytics/ES|QL AKA ESQL labels Apr 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine elasticsearchmachine removed the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 22, 2024
@dnhatn dnhatn added low-risk An open issue or test failure that is a low risk to future releases and removed blocker labels Apr 24, 2024
@dnhatn dnhatn mentioned this issue May 1, 2024
Merged
@dnhatn dnhatn closed this as completed in 1bf9563 May 2, 2024
dnhatn added a commit to dnhatn/elasticsearch that referenced this issue May 8, 2024
@dnhatn
Remove time-series ordinal rate tests in ESQL (elastic#108148)
b90601d 
The rate aggregation will only be used in time-series aggregations,
where ordinal grouping should never be applied. Therefore, we should
remove these tests to reduce unnecessary noise.

Closes elastic#107568
Closes elastic#107710
@dnhatn dnhatn mentioned this issue May 8, 2024
Merged
elasticsearchmachine pushed a commit that referenced this issue May 8, 2024
@dnhatn
Remove time-series ordinal rate tests in ESQL (#108148) (#108442)
bfe1df5 
The rate aggregation will only be used in time-series aggregations,
where ordinal grouping should never be applied. Therefore, we should
remove these tests to reduce unnecessary noise.

Closes #107568
Closes #107710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnhatn dnhatn

Labels
low-risk An open issue or test failure that is a low risk to future releases :StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove time-series ordinal rate tests in ESQL dnhatn/elasticsearch
3 participants
@dnhatn @elasticsearchmachine @maxhniebergall